1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 11:22:40 +01:00
phorge-phorge/src/applications/search
epriestley 7050506267 Fix a bad getURI() call in Profile Panel handle construction
Summary:
Fixes T11285. We can end up loading panel handles while processing edits (e.g., disabling menu items on a project). We probably started loading these after the modular transaction changes in T9789, which load the handle for the transaction object unconditionally.

The handles aren't too useful, but they currently fail to load/build because panels don't have a URI. We could give them some sort of method here, but just nuke it for now since they don't appear anywhere and this unclogs the daemon queue.

Test Plan:
  - Disabled a menu item on a project.
  - Ran publish task with `bin/worker execute --id <id>`.
  - Before patch: fatal on getURI() with stack trace similar to T11285.
  - After patch: clean execution.

Reviewers: chad, avivey

Reviewed By: avivey

Maniphest Tasks: T11285

Differential Revision: https://secure.phabricator.com/D16249
2016-07-07 14:55:47 -07:00
..
application Convert Maniphest merge operations to modern Relationship code 2016-06-30 08:35:45 -07:00
applicationpanel Rename "SearchEngine" to "FulltextStorageEngine" 2015-12-21 17:26:19 -08:00
buckets Use new Differential bucketing logic on default (non-dashboard) homepage 2016-05-19 15:20:39 -07:00
config Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
constants Extend from Phobject 2015-06-15 18:02:27 +10:00
controller When using the "Close as Duplicate" relationship action, limit the UI to 1 task 2016-06-30 13:48:21 -07:00
editor Update EditEngine for two column 2016-03-28 09:18:55 -07:00
engine Modernize various menu collapse settings 2016-06-04 14:44:36 -07:00
engineextension Move PhabricatorHovercard to PHUIHovercard 2016-02-03 16:26:30 +00:00
field Add a modern user.search Conduit API method 2016-05-22 05:54:31 -07:00
fulltextstorage Rename "SearchEngine" to "FulltextStorageEngine" 2015-12-21 17:26:19 -08:00
index Allow index extensions to skip indexing if the object has not changed 2015-12-21 17:27:14 -08:00
interface Prepare Profile Panels for adoption in other applications 2016-01-15 09:12:53 -08:00
management Rename "SearchEngine" to "FulltextStorageEngine" 2015-12-21 17:26:19 -08:00
ngrams Implement basic ngram search for Owners Package names 2015-12-22 08:00:33 -08:00
phidtype Fix a bad getURI() call in Profile Panel handle construction 2016-07-07 14:55:47 -07:00
profilepanel Disable "Subprojects" menu item for milestone projects 2016-02-06 12:55:05 -08:00
query Use "tag" more consistenty when referring to associating a project with an object 2016-01-24 10:02:42 -08:00
relationship Render parent and child tasks in Maniphest with a graph trace 2016-07-01 10:41:07 -07:00
storage Refine available filters and defaults for relationship selection 2016-06-30 11:51:36 -07:00
typeahead Render browse results with global result style 2016-06-20 16:49:02 -07:00
view Revert "Allow search results to be snippeted, roughly" 2015-09-10 20:57:26 -07:00
worker Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00