revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 01:12:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 70f6bf306f Implement child/descendant query rules in Projects 
Summary:
Ref T10010. This adds infrastructure for querying projects by type, depth, parent and ancestor.

I needed to revise the "extended policy check" cycle detection rules. When, e.g., querying a grandchild, they incorrectly detected a cycle because both the child and grandchild needed to check the policy of the grandparent.

Instead, simplify it to just do a basic runaway calldepth check. There are many other safety mechanisms to make it so this can't ever occur.

(Cycle detection does have existing test coverage, and those tests still pass, it just takes a little longer to detect the cycle internally.)

There is still no way to create subprojects in the UI.

Test Plan: Added and executed unit tests.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10010

Differential Revision: https://secure.phabricator.com/D14862
2015-12-23 14:38:51 -08:00
..
almanac Prepare DestructionEngine to be modularized 2015-12-21 17:03:32 -08:00
aphlict Update "should not run as root" message 2015-10-31 11:20:23 +00:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit More NUX states 2015-12-21 13:13:44 -08:00
auth Provide a more straightforward way to revoke SSH keys by finding and destroying the objects 2015-12-19 11:52:26 -08:00
badges Fix two issues with Phurl / Badges mail generation 2015-12-22 08:19:53 -08:00
base Clean up some EditEngine meta-policies 2015-12-07 15:40:31 -08:00
cache Write 500 words on how to restart webservers 2015-12-02 09:16:10 -08:00
calendar Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
celerity Add mask-icon for Safari pinned tab 2015-11-22 13:04:06 -08:00
chatlog Update Chatlog for handleRequest 2015-07-31 09:14:44 -07:00
conduit Continue hammering new *.search / *.edit documentation into shape 2015-12-16 08:46:05 -08:00
config Implement query and policy rules for subprojects 2015-12-23 14:38:35 -08:00
conpherence Lift Conpherence indexing up out of the Fulltext index 2015-12-21 17:25:05 -08:00
console Push construction of routing maps into Sites 2015-08-31 04:01:01 -07:00
countdown Add various NUX states 2015-12-21 09:55:54 -08:00
daemon Remove daemon envHash and envInfo 2015-11-11 08:54:45 +11:00
dashboard Add more NUX states 2015-12-21 11:15:54 -08:00
differential Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
diffusion Remove all setObjectURI() from ActionListViews 2015-12-17 08:30:22 -08:00
diviner Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
doorkeeper JIRA Integration: Link and/or Comment 2015-11-12 19:30:43 +00:00
draft/storage Fix EditEngine preview/draft for first comment on a task you didn't create 2015-12-05 09:57:45 -08:00
drydock In Drydock, don't reset current branch to point at unrelated commit 2015-12-22 06:47:47 -08:00
fact Update Facts for handleRequest 2015-07-27 09:12:35 -07:00
feed Remove some low-hanging buildStandardPageResponse() methods 2015-11-03 10:11:36 -08:00
files More NUX states 2015-12-21 13:13:44 -08:00
flag Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
fund Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
harbormaster Remove all setObjectURI() from ActionListViews 2015-12-17 08:30:22 -08:00
help Remove some low-hanging buildStandardPageResponse() methods 2015-11-03 10:11:36 -08:00
herald Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
home Drop "Quick Create" header from quick create menu 2015-12-07 13:43:54 -08:00
legalpad More NUX states 2015-12-21 13:13:44 -08:00
lipsum Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
macro Add various NUX states 2015-12-21 09:55:54 -08:00
maniphest Always show "Change Priority" Maniphest stacked action, even for closed tasks 2015-12-23 13:43:51 -08:00
meta Remove all setObjectURI() from ActionListViews 2015-12-17 08:30:22 -08:00
metamta Fix a potentially lax hash comparison 2015-11-10 10:22:25 -08:00
multimeter Various translation improvements 2015-11-03 07:02:46 +11:00
notification Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
nuance Remove all setObjectURI() from ActionListViews 2015-12-17 08:30:22 -08:00
oauthserver Linter fixes 2015-12-03 07:44:23 +11:00
owners Implement basic ngram search for Owners Package names 2015-12-22 08:00:33 -08:00
passphrase Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
paste Add various NUX states 2015-12-21 09:55:54 -08:00
people Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
phame Add some more consistant NUX to Phame 2015-12-22 07:12:17 -08:00
phid Provide formal Users/Projects/Mailable fields for EditEngine 2015-11-04 12:05:41 -08:00
phlux Remove all setObjectURI() from ActionListViews 2015-12-17 08:30:22 -08:00
pholio Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
phortune Remove all setObjectURI() from ActionListViews 2015-12-17 08:30:22 -08:00
phpast Show node IDs in XHPAST tree view 2015-12-23 08:39:24 +11:00
phragment Remove all setObjectURI() from ActionListViews 2015-12-17 08:30:22 -08:00
phrequent Make notification counts properly translatable 2015-12-03 07:06:39 -08:00
phriction Basic NUX states for Phriction 2015-12-22 12:14:44 -08:00
phurl Fix two issues with Phurl / Badges mail generation 2015-12-22 08:19:53 -08:00
policy Implement child/descendant query rules in Projects 2015-12-23 14:38:51 -08:00
ponder Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
project Implement child/descendant query rules in Projects 2015-12-23 14:38:51 -08:00
releeph Remove all setObjectURI() from ActionListViews 2015-12-17 08:30:22 -08:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
search Implement basic ngram search for Owners Package names 2015-12-22 08:00:33 -08:00
settings Remove Certificate page 2015-11-04 06:35:22 +00:00
slowvote Add various NUX states 2015-12-21 09:55:54 -08:00
spaces More NUX states 2015-12-21 13:13:44 -08:00
subscriptions Modularize fulltext indexing of Projects, Subscriptions and Custom Fields 2015-12-21 17:04:25 -08:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
tokens Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
transactions Put inline previews in remarkup textareas 2015-12-22 12:18:28 -08:00
typeahead Save stacked actions in drafts, not just comments 2015-12-04 16:29:43 -08:00
uiexample More ActionPanel colors, hardening 2015-09-16 09:22:31 -07:00
xhprof Update XHProf for handleRequest 2015-08-01 15:41:57 -07:00