epriestley f68d67530a Fix an issue with pulling Subversion blame data ... Summary: Fixes T4067. The way `DiffusionCommitQuery` works prevents it from loading SVN identifiers in some cases without additional constraints, since "12345" might be an SVN revision 12345, or it might be the first 5 characters of a Git commit hash. Introduce `withRepository()` as a shorthand for `withDefaultRepository()` + `withRepositoryIDs()`. This tells the query to: - Only look in the given repository; and - use the more liberal identifier resolution rules while doing so. The practical impact this has is that blame tooltips in SVN work again. The other queries which are fixed here were never run in SVN (which doesn't have first-class branches or tags); I've cleaned them up only for completeness. Test Plan: - Viewed blame in SVN, saw information again instead of empty tooltip. - Viewed brnaches/tags in Mercurial and Git. {F79226} Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T4067 Differential Revision: https://secure.phabricator.com/D7523		2013-11-07 12:10:43 -08:00
..
DiffusionBranchTableController.php	Fix an issue with pulling Subversion blame data	2013-11-07 12:10:43 -08:00
DiffusionBrowseController.php	Fix tag content display in Git	2013-11-04 12:16:53 -08:00
DiffusionBrowseDirectoryController.php	PHUIPropertyListView	2013-10-11 07:53:56 -07:00
DiffusionBrowseFileController.php	Fix an issue with pulling Subversion blame data	2013-11-07 12:10:43 -08:00
DiffusionBrowseMainController.php	Improve organization of Diffusion browse controllers	2013-09-19 16:01:34 -07:00
DiffusionBrowseSearchController.php	PHUIPropertyListView	2013-10-11 07:53:56 -07:00
DiffusionChangeController.php	PHUIPropertyListView	2013-10-11 07:53:56 -07:00
DiffusionCommitBranchesController.php	Make more Diffusion controllers/views capability-sensitive	2013-09-27 10:49:45 -07:00
DiffusionCommitController.php	Add header icons to PHUIPropertyListView	2013-11-04 11:07:51 -08:00
DiffusionCommitEditController.php	Always pass handles to tokenizers, not <phid -> name> maps	2013-10-07 12:51:24 -07:00
DiffusionCommitTagsController.php	Make more Diffusion controllers/views capability-sensitive	2013-09-27 10:49:45 -07:00
DiffusionController.php	Split Diffusion VSC serve code into its own controller	2013-11-06 17:55:46 -08:00
DiffusionDiffController.php	Modernize Diffusion "change" view	2013-09-23 12:54:12 -07:00
DiffusionExternalController.php	Make more Diffusion controllers/views capability-sensitive	2013-09-27 10:49:45 -07:00
DiffusionHistoryController.php	PHUIPropertyListView	2013-10-11 07:53:56 -07:00
DiffusionInlineCommentController.php	Delete license headers from files	2012-11-05 11:16:51 -08:00
DiffusionInlineCommentPreviewController.php	Delete license headers from files	2012-11-05 11:16:51 -08:00
DiffusionLastModifiedController.php	Make more Diffusion controllers/views capability-sensitive	2013-09-27 10:49:45 -07:00
DiffusionLintController.php	PHUIPropertyListView	2013-10-11 07:53:56 -07:00
DiffusionLintDetailsController.php	Mostly modernize lint views and delete dead code	2013-09-23 12:55:47 -07:00
DiffusionPathCompleteController.php	Make most repository reads policy-aware	2013-09-25 16:54:48 -07:00
DiffusionPathValidateController.php	Make most repository reads policy-aware	2013-09-25 16:54:48 -07:00
DiffusionRepositoryController.php	Fix an issue with pulling Subversion blame data	2013-11-07 12:10:43 -08:00
DiffusionRepositoryCreateController.php	When creating a repository in Diffusion, prompt for "Create" or "Import" first	2013-11-01 17:39:35 -07:00
DiffusionRepositoryDefaultController.php	Accept and route VCS HTTP requests	2013-10-29 15:32:40 -07:00
DiffusionRepositoryEditActionsController.php	Sort out application crumbs in new repository edit workflow	2013-10-25 15:58:58 -07:00
DiffusionRepositoryEditActivateController.php	Sort out application crumbs in new repository edit workflow	2013-10-25 15:58:58 -07:00
DiffusionRepositoryEditBasicController.php	Sort out application crumbs in new repository edit workflow	2013-10-25 15:58:58 -07:00
DiffusionRepositoryEditBranchesController.php	Make Phabricator clone bare git repositories	2013-10-29 15:32:41 -07:00
DiffusionRepositoryEditController.php	Provide detailed status information about repository state/progress	2013-10-30 13:15:32 -07:00
DiffusionRepositoryEditDeleteController.php	Move "Delete Repository" stuff to Diffusion	2013-10-29 12:26:07 -07:00
DiffusionRepositoryEditEncodingController.php	Sort out application crumbs in new repository edit workflow	2013-10-25 15:58:58 -07:00
DiffusionRepositoryEditHostingController.php	Improve repository hinting and feedback	2013-11-01 17:35:43 -07:00
DiffusionRepositoryEditLocalController.php	Move editing "Local Path" to modern UI/controller/etc	2013-10-29 12:20:26 -07:00
DiffusionRepositoryEditMainController.php	Expand "local working copy" conditional check in Diffusion	2013-11-05 10:01:44 -08:00
DiffusionRepositoryEditPolicyController.php	Add hosting, serving, and push policy options to repository edit	2013-10-29 15:32:40 -07:00
DiffusionRepositoryEditSubversionController.php	Sort out application crumbs in new repository edit workflow	2013-10-25 15:58:58 -07:00
DiffusionRepositoryListController.php	When creating a repository in Diffusion, prompt for "Create" or "Import" first	2013-11-01 17:39:35 -07:00
DiffusionRepositoryNewController.php	When creating a repository in Diffusion, prompt for "Create" or "Import" first	2013-11-01 17:39:35 -07:00
DiffusionServeController.php	Allow Phabricator to serve Mercurial repositories over HTTP	2013-11-06 18:00:42 -08:00
DiffusionSymbolController.php	Remove dust from page construction	2013-08-19 18:09:35 -07:00
DiffusionTagListController.php	Fix an issue with pulling Subversion blame data	2013-11-07 12:10:43 -08:00