1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-08 22:01:03 +01:00
phorge-phorge/src/infrastructure
Steve Campbell 73253489bf Make src/infrastructure/javelin/markup.php phabricator_form PHP 8.1 compliant
Summary:
src/infrastructure/javelin/markup.php phabricator_form() performs a strcasecmp() operation on an optional attribute withoiut checking to see if it exists first. This causes an 'Passing null to parameter #1 ($string1) of type string is deprecated' error.

Because we subsequenly check to see that the value equals /POST/i, all we need to do is check that the value has some 'true' value before doing the strcasecmp(). If it's not true, then it won't be POST!

Fixes T15509

Test Plan: View a diff. Eg: https://my.phorge.site/D1234

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15509

Differential Revision: https://we.phorge.it/D25319
2023-06-30 15:13:20 +01:00
..
cache Use "@" to silence "GC list" warnings from "apc_store()" and "apcu_store()" 2020-04-28 04:13:37 -07:00
cluster Fix PHP 8.1 strlen() error when database replication Seconds_Behind_Master is NULL 2023-06-30 13:49:32 +01:00
contentsource Fix PHP 8.1 "strlen(null)" exception which blocks creating personal and global Herald rules 2023-05-05 12:53:14 +02:00
customfield Fix PHP 8.1 "strlen(null)" exception which blocks rendering errors on Create Blueprint page 2023-06-10 22:58:28 +02:00
daemon Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
diff Fix PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web interface 2023-06-02 20:40:42 +02:00
edges Add a side nav to Conduit API method console pages 2021-07-21 14:16:59 -07:00
editor Restore editor behavior to Diffusion and support "\" shortcut 2020-04-19 09:41:37 -07:00
env PHP 8.2: fixes for strlen() not accepting NULL anymore, part 1 2023-03-31 22:05:52 +02:00
events Remove "PhabricatorEventType::TYPE_DIFFUSION_LOOKUPUSER" event 2019-11-19 09:38:03 -08:00
export Remove product literal strings in "pht()", part 9 2022-04-25 12:22:29 -07:00
graph Render user hovercards with context information about their ability to see the context object 2021-02-13 13:37:37 -08:00
internationalization Update "Files" attachment table to show more attachment details and support detachment 2022-05-25 12:56:37 -07:00
javelin Make src/infrastructure/javelin/markup.php phabricator_form PHP 8.1 compliant 2023-06-30 15:13:20 +01:00
lint/linter Linter fixes 2015-12-03 07:44:23 +11:00
lipsum Continue moving classes with no callers in libphutil or Arcanist to Phabricator 2020-02-12 13:14:04 -08:00
log PHP 8.2: fixes for strlen() not accepting NULL anymore, part 1 2023-03-31 22:05:52 +02:00
management Add additional flags to "bin/repository rebuild-identities" to improve flexibility 2019-11-19 09:39:48 -08:00
markup Fix PHP 8.1 "trim(null)" exception which blocks rendering Conduit's harbormaster.sendmessage page 2023-06-10 16:26:49 +02:00
parser Correct spelling mistakes 2023-05-27 22:19:06 +01:00
query Fix PHP 8.1 "strlen(null)" and preg_match() exceptions which block rendering "Browse Subscribers" overlay dialog 2023-05-12 12:02:15 +02:00
ssh Generate a random unique "Request ID" for SSH requests so processes can coordinate better 2018-03-22 13:44:30 -07:00
status Give Drydock Leases more modern status treatment 2018-02-13 13:15:57 -08:00
storage Fix PHP 8.1 "strlen(null)" exceptions creating a Diffusion Identity without entering assignee 2023-06-08 14:52:26 +02:00
syntax Pass the new default syntax highlighting map to the remarkup engine 2016-05-05 02:51:19 -07:00
testing When running unit tests, ignore any custom task fields 2017-04-02 09:36:17 -07:00
time Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles"). 2019-05-30 15:03:11 -07:00
util Remove product literal strings in "pht()", part 25 2022-04-25 16:46:26 -07:00
PhabricatorEditor.php Mark some strings for translation 2015-06-09 23:06:52 +10:00