1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-24 13:38:19 +01:00
phorge-phorge/src/infrastructure/contentsource
Andre Klapper b0044bad62 Fix PHP 8.1 "strlen(null)" exception which blocks creating personal and global Herald rules
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15348

Test Plan:
Applied this change (on top of D25157) and creation form at `/herald/edit/?content_type=HeraldPreCommitRefAdapter&rule_type=personal` rendered in web browser.
Same applies for other types of personal and global Herald rules.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15348

Differential Revision: https://we.phorge.it/D25190
2023-05-05 12:53:14 +02:00
..
PhabricatorConduitContentSource.php Modularize content sources 2016-03-26 11:59:45 -07:00
PhabricatorConsoleContentSource.php Modularize content sources 2016-03-26 11:59:45 -07:00
PhabricatorContentSource.php Fix PHP 8.1 "strlen(null)" exception which blocks creating personal and global Herald rules 2023-05-05 12:53:14 +02:00
PhabricatorContentSourceModule.php Redesign Config Application 2016-08-29 15:49:49 -07:00
PhabricatorContentSourceView.php Modularize content sources 2016-03-26 11:59:45 -07:00
PhabricatorFaxContentSource.php Modularize content sources 2016-03-26 11:59:45 -07:00
PhabricatorLipsumContentSource.php Modularize content sources 2016-03-26 11:59:45 -07:00
PhabricatorOldWorldContentSource.php Modularize content sources 2016-03-26 11:59:45 -07:00
PhabricatorUnitTestContentSource.php Modularize content sources 2016-03-26 11:59:45 -07:00
PhabricatorUnknownContentSource.php Fix PHP 8.1 "strlen(null)" exception which blocks creating personal and global Herald rules 2023-05-05 12:53:14 +02:00
PhabricatorWebContentSource.php Modularize content sources 2016-03-26 11:59:45 -07:00