revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-27 16:00:59 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/view/phui
History
Thai Pham 78bd6c1ce4 Ensure that PHUIInvisibleCharacterTestCase is compatible with PHP 5.3 
Summary: This diff fixes the `PHUIInvisibleCharacterTestCase` unittest which is only broken when running in PHP 5.3.

Test Plan:
I wasn't able to run `arc unit` successfully for some reason.
```
arc diff master
Linting...
 LINT OKAY  No lint problems.
Running unit tests...
PHP Fatal error:  Class PhabricatorUser contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PhutilPerson::getSex) in /home/thai/workspace/phabricator/phabricator/src/applications/people/storage/PhabricatorUser.php on line 1517
PHP Stack trace:
PHP   1. {main}() /home/thai/workspace/phabricator/arcanist/scripts/arcanist.php:0
PHP   2. ArcanistDiffWorkflow->run() /home/thai/workspace/phabricator/arcanist/scripts/arcanist.php:394
PHP   3. ArcanistDiffWorkflow->runLintUnit() /home/thai/workspace/phabricator/arcanist/src/workflow/ArcanistDiffWorkflow.php:483
PHP   4. ArcanistDiffWorkflow->runUnit() /home/thai/workspace/phabricator/arcanist/src/workflow/ArcanistDiffWorkflow.php:1228
PHP   5. ArcanistUnitWorkflow->run() /home/thai/workspace/phabricator/arcanist/src/workflow/ArcanistDiffWorkflow.php:1340
PHP   6. ArcanistConfigurationDrivenUnitTestEngine->run() /home/thai/workspace/phabricator/arcanist/src/workflow/ArcanistUnitWorkflow.php:167
PHP   7. PhutilUnitTestEngine->run() /home/thai/workspace/phabricator/arcanist/src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php:147
PHP   8. PhabricatorTestCase->willRunTestCases() /home/thai/workspace/phabricator/arcanist/src/unit/engine/PhutilUnitTestEngine.php:64
PHP   9. require_once() /home/thai/workspace/phabricator/phabricator/src/infrastructure/testing/PhabricatorTestCase.php:62
PHP  10. require_once() /home/thai/workspace/phabricator/phabricator/scripts/__init_script__.php:3
PHP  11. init_phabricator_script() /home/thai/workspace/phabricator/phabricator/scripts/init/init-script.php:10
PHP  12. PhabricatorEnv::initializeScriptEnvironment() /home/thai/workspace/phabricator/phabricator/scripts/init/lib.php:22
PHP  13. PhabricatorEnv::initializeCommonEnvironment() /home/thai/workspace/phabricator/phabricator/src/infrastructure/env/PhabricatorEnv.php:75
PHP  14. PhabricatorEnv::buildConfigurationSourceStack() /home/thai/workspace/phabricator/phabricator/src/infrastructure/env/PhabricatorEnv.php:95
PHP  15. PhabricatorConfigDefaultSource->__construct() /home/thai/workspace/phabricator/phabricator/src/infrastructure/env/PhabricatorEnv.php:183
PHP  16. PhabricatorApplicationConfigOptions::loadAllOptions() /home/thai/workspace/phabricator/phabricator/src/infrastructure/env/PhabricatorConfigDefaultSource.php:11
PHP  17. PhabricatorUserConfigOptions->getOptions() /home/thai/workspace/phabricator/phabricator/src/applications/config/option/PhabricatorApplicationConfigOptions.php:232
PHP  18. spl_autoload_call() /home/thai/workspace/phabricator/phabricator/src/applications/config/option/PhabricatorApplicationConfigOptions.php:44
PHP  19. __phutil_autoload() /home/thai/workspace/phabricator/phabricator/src/applications/config/option/PhabricatorApplicationConfigOptions.php:44
PHP  20. PhutilSymbolLoader->selectAndLoadSymbols() /home/thai/workspace/phabricator/libphutil/src/__phutil_library_init__.php:22
PHP  21. PhutilSymbolLoader->loadSymbol() /home/thai/workspace/phabricator/libphutil/src/symbols/PhutilSymbolLoader.php:256
PHP  22. PhutilBootloader->loadLibrarySource() /home/thai/workspace/phabricator/libphutil/src/symbols/PhutilSymbolLoader.php:381
PHP  23. PhutilBootloader->executeInclude() /home/thai/workspace/phabricator/libphutil/src/moduleutils/PhutilBootloader.php:216
PHP  24. include_once() /home/thai/workspace/phabricator/libphutil/src/moduleutils/PhutilBootloader.php:226

Fatal error: Class PhabricatorUser contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PhutilPerson::getSex) in /home/thai/workspace/phabricator/phabricator/src/applications/people/storage/PhabricatorUser.php on line 1517

Call Stack:
    0.0006     364056   1. {main}() /home/thai/workspace/phabricator/arcanist/scripts/arcanist.php:0
    0.7499   12720888   2. ArcanistDiffWorkflow->run() /home/thai/workspace/phabricator/arcanist/scripts/arcanist.php:394
  358.7140   13762072   3. ArcanistDiffWorkflow->runLintUnit() /home/thai/workspace/phabricator/arcanist/src/workflow/ArcanistDiffWorkflow.php:483
  431.5813   40844984   4. ArcanistDiffWorkflow->runUnit() /home/thai/workspace/phabricator/arcanist/src/workflow/ArcanistDiffWorkflow.php:1228
  431.5825   40848752   5. ArcanistUnitWorkflow->run() /home/thai/workspace/phabricator/arcanist/src/workflow/ArcanistDiffWorkflow.php:1340
  431.5836   40966456   6. ArcanistConfigurationDrivenUnitTestEngine->run() /home/thai/workspace/phabricator/arcanist/src/workflow/ArcanistUnitWorkflow.php:167
  431.5866   41403128   7. PhutilUnitTestEngine->run() /home/thai/workspace/phabricator/arcanist/src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php:147
  431.5882   41655352   8. PhabricatorTestCase->willRunTestCases() /home/thai/workspace/phabricator/arcanist/src/unit/engine/PhutilUnitTestEngine.php:64
  431.5882   41657288   9. require_once('/home/thai/workspace/phabricator/phabricator/scripts/__init_script__.php') /home/thai/workspace/phabricator/phabricator/src/infrastructure/testing/PhabricatorTestCase.php:62
  431.5882   41659560  10. require_once('/home/thai/workspace/phabricator/phabricator/scripts/init/init-script.php') /home/thai/workspace/phabricator/phabricator/scripts/__init_script__.php:3
  431.5883   41667040  11. init_phabricator_script() /home/thai/workspace/phabricator/phabricator/scripts/init/init-script.php:10
  431.5889   41863352  12. PhabricatorEnv::initializeScriptEnvironment() /home/thai/workspace/phabricator/phabricator/scripts/init/lib.php:22
  431.5889   41863584  13. PhabricatorEnv::initializeCommonEnvironment() /home/thai/workspace/phabricator/phabricator/src/infrastructure/env/PhabricatorEnv.php:75
  431.5889   41866848  14. PhabricatorEnv::buildConfigurationSourceStack() /home/thai/workspace/phabricator/phabricator/src/infrastructure/env/PhabricatorEnv.php:95
  431.5893   41938352  15. PhabricatorConfigDefaultSource->__construct() /home/thai/workspace/phabricator/phabricator/src/infrastructure/env/PhabricatorEnv.php:183
  431.5895   42010944  16. PhabricatorApplicationConfigOptions::loadAllOptions() /home/thai/workspace/phabricator/phabricator/src/infrastructure/env/PhabricatorConfigDefaultSource.php:11
  431.6188   50463016  17. PhabricatorUserConfigOptions->getOptions() /home/thai/workspace/phabricator/phabricator/src/applications/config/option/PhabricatorApplicationConfigOptions.php:232
  431.6200   50901600  18. spl_autoload_call() /home/thai/workspace/phabricator/phabricator/src/applications/config/option/PhabricatorApplicationConfigOptions.php:44
  431.6200   50901632  19. __phutil_autoload() /home/thai/workspace/phabricator/phabricator/src/applications/config/option/PhabricatorApplicationConfigOptions.php:44
  431.6200   50901848  20. PhutilSymbolLoader->selectAndLoadSymbols() /home/thai/workspace/phabricator/libphutil/src/__phutil_library_init__.php:22
  431.6200   50904176  21. PhutilSymbolLoader->loadSymbol() /home/thai/workspace/phabricator/libphutil/src/symbols/PhutilSymbolLoader.php:256
  431.6200   50904224  22. PhutilBootloader->loadLibrarySource() /home/thai/workspace/phabricator/libphutil/src/symbols/PhutilSymbolLoader.php:381
  431.6200   50904392  23. PhutilBootloader->executeInclude() /home/thai/workspace/phabricator/libphutil/src/moduleutils/PhutilBootloader.php:216
  431.6210   51263432  24. include_once('/home/thai/workspace/phabricator/phabricator/src/applications/people/storage/PhabricatorUser.php') /home/thai/workspace/phabricator/libphutil/src/moduleutils/PhutilBootloader.php:226
```

Reviewers: chad, joshuaspence, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D16875
2016-11-15 14:46:22 -08:00
..
__tests__ Ensure that PHUIInvisibleCharacterTestCase is compatible with PHP 5.3 2016-11-15 14:46:22 -08:00
calendar Probably fix some display issues with all-day events? 2016-11-07 10:55:30 -08:00
PHUI.php Remove unused call to phui-text 2016-01-29 12:41:04 -08:00
PHUIActionPanelView.php Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
PHUIBadgeBoxView.php PHUIBadgeMiniView 2015-07-10 10:49:28 -07:00
PHUIBadgeMiniView.php Converting badge quality property from color to an integer representation for later sorting purposes 2016-03-30 17:28:34 -07:00
PHUIBadgeView.php Links on badge card should be accessible 2016-04-15 07:55:31 -07:00
PHUIBigInfoView.php Convert all calls to 'IconFont' to just 'Icon' 2016-01-27 20:59:27 -08:00
PHUIBoxView.php Add basic grey and blue styles for PHUIBoxView 2016-01-21 07:14:39 -08:00
PHUIButtonBarView.php [Redesign] Update Inline Comment UI 2015-06-29 14:42:29 -07:00
PHUIButtonView.php Fold task-relationship actions into an accordion dropdown 2016-06-20 19:14:27 -07:00
PHUICMSView.php Rough in Guides Application 2016-08-17 10:14:05 -07:00
PHUICrumbsView.php Add fullscreen mode to Workboards 2016-02-10 15:31:02 +00:00
PHUICrumbView.php Put boundary spaces around crumb names so double-clicking doesn't flip out 2016-02-12 11:13:38 -08:00
PHUIDocumentSummaryView.php Add a Read More link to PHUIDocumentSummaryView 2015-12-19 12:49:23 -08:00
PHUIDocumentViewPro.php Convert all calls to 'IconFont' to just 'Icon' 2016-01-27 20:59:27 -08:00
PHUIFeedStoryView.php Strip timestamps from popup notification bubbles 2016-07-08 07:46:09 -07:00
PHUIHeaderView.php Require several advanced postgraduate degrees to understand object policies 2016-11-09 15:05:38 -08:00
PHUIHeadThingView.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
PHUIHovercardView.php Fix header tag on Hovercards 2016-03-05 15:25:06 +00:00
PHUIIconCircleView.php Clean up some Conpherence header CSS 2016-09-14 21:13:25 -07:00
PHUIIconView.php Add setBackground to PHUIIconView 2016-08-19 13:19:53 -07:00
PHUIImageMaskView.php Fix AphrontTagView visibility 2015-01-14 06:54:39 +11:00
PHUIInfoPanelView.php Minor linter fixes 2014-12-30 02:48:03 -08:00
PHUIInvisibleCharacterView.php Added initial class for displaying invisible chars 2016-09-12 21:57:01 -04:00
PHUIListItemView.php Open "Help" menu links in a new window 2016-07-04 10:59:40 -07:00
PHUIListView.php Improve handle loading semantics for tokenizers 2015-04-02 13:42:01 -07:00
PHUIMainMenuView.php Begin modularizing main menu items 2016-01-04 06:57:09 -08:00
PHUIObjectBoxView.php Redesign Application Search 2016-08-01 12:23:36 -07:00
PHUIObjectItemListView.php Move Guides ObjectList styles to PHUIObjectItemListView 2016-08-29 09:27:10 -07:00
PHUIObjectItemView.php Fix some more setIcon() issues 2016-08-31 10:00:03 -07:00
PHUIPagerView.php Redesign Application Search 2016-08-01 12:23:36 -07:00
PHUIPinboardItemView.php Convert all calls to 'IconFont' to just 'Icon' 2016-01-27 20:59:27 -08:00
PHUIPinboardView.php [Redesign] Center Pinboard Items 2015-05-31 14:28:16 -07:00
PHUIPropertyGroupView.php PHUIPropertyListView 2013-10-11 07:53:56 -07:00
PHUIPropertyListView.php Disambiguate isEmpty() 2016-01-31 15:20:04 -08:00
PHUIRemarkupPreviewPanel.php Use PHUIRemarkupPreviewView in Phame 2015-11-23 10:36:02 -08:00
PHUISegmentBarSegmentView.php Add a basic progress bar for milestones 2016-02-08 18:50:22 -08:00
PHUISegmentBarView.php First cut of progress bars (PHUISegmentBarView) 2016-02-08 15:28:09 -08:00
PHUIStatusItemView.php Update Calendar for PHUITwoColumnView 2016-03-02 18:12:42 -08:00
PHUIStatusListView.php Fix AphrontTagView visibility 2015-01-14 06:54:39 +11:00
PHUITabGroupView.php Remove old ObjectBox tab cruft 2016-06-30 18:50:25 -07:00
PHUITabView.php Build that thing someone posted a screenshot of on Facebook 2016-07-01 04:36:24 -07:00
PHUITagView.php Move PhabricatorHovercard to PHUIHovercard 2016-02-03 16:26:30 +00:00
PHUITimelineEventView.php Fold task-relationship actions into an accordion dropdown 2016-06-20 19:14:27 -07:00
PHUITimelineView.php Changing criteria for showing badges in object timeline view 2016-03-30 11:35:21 -07:00
PHUITwoColumnView.php Clean up recurring event information on Calendar events 2016-07-28 10:59:28 -07:00
PHUIWorkboardView.php Only prevent drag-scroll in the Y direction on workboards 2016-02-08 10:05:39 -08:00
PHUIWorkpanelView.php Expand scope of addActionItem in PHUIHeaderView 2016-03-04 18:35:05 -08:00