revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/diffusion
History
epriestley 7a39ac43b4 Add a "list<regex>" config option and move regex config to it 
Summary:
Fixes T3807. Several issues:

  - Currently, we split config of type `list<string>` on commas, which makes it impossible to enter a regex with a comma in it.
    - Split on newlines only.
  - Some of the examples are confusing (provided in JSON instead of the format you actually have to enter them).
    - Show examples in the same format you should enter text.
  - We didn't validate regexps.
    - Introduce `list<regex>` to validate regexes.

@hlau: Note that the old config format for the bugtraq stuff implied the delimiters on the regular expression. They are no longer implied. The examples show the correct format.

Test Plan: Viewed and edited affected config, hitting error and success cases.

Reviewers: btrahan

Reviewed By: btrahan

CC: hlau, aran

Maniphest Tasks: T3807

Differential Revision: https://secure.phabricator.com/D6969
2013-09-13 11:48:00 -07:00
..
application Use ApplicationSearch in Diffusion 2013-09-10 15:26:08 -07:00
conduit Add "diffusion.createcomment" conduit endpoint 2013-09-09 14:25:18 -07:00
config Add a "list<regex>" config option and move regex config to it 2013-09-13 11:48:00 -07:00
controller Fix a second minor merge issue 2013-09-10 15:42:37 -07:00
data Diffusion - double check these sub objects exist before toDictionary'ing them 2013-05-21 13:48:24 -07:00
doorkeeper Kill PhabricatorObjectDataHandle 2013-09-11 12:27:28 -07:00
events Kill PhabricatorObjectDataHandle 2013-09-11 12:27:28 -07:00
exception Diffusion - move some DiffusionRequest queries to occur over Conduit 2013-05-14 15:32:19 -07:00
query Pass branch information to local Conduit calls in Diffusion 2013-08-13 10:11:15 -07:00
remarkup Use Application PHIDs for commits 2013-07-22 12:17:34 -07:00
request Diffusion - move querying for stable commit name to occur over conduit 2013-05-17 14:12:46 -07:00
view Modernize Diffusion 2013-05-11 08:23:19 -07:00
DiffusionLintSaveRunner.php Diffusion - move some DiffusionRequest queries to occur over Conduit 2013-05-14 15:32:19 -07:00