1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 03:32:42 +01:00
phorge-phorge/src/applications/transactions
Andre Klapper 72fdf232b4 Fix PHP 8.1 "strlen(null)" exception which blocks rendering Conduit's dashboard.panel.edit page
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15425

Test Plan: Applied this change; afterwards `/conduit/method/dashboard.panel.edit/` correctly renders in browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15425

Differential Revision: https://we.phorge.it/D25257
2023-05-30 10:57:43 +02:00
..
application Allow EditEngine forms for objects which support subtyping to have a subtype configured 2017-03-02 04:18:06 -08:00
bulk Fix PHP 8.1 "strlen(null)" exception which blocks task Bulk Editor page 2023-05-20 11:46:38 +02:00
commentaction When you "Request Review" of a draft revision, change the button text from "Submit Quietly" to "Publish Revision" 2018-11-15 20:50:21 -08:00
conduit Correct spelling mistakes 2023-05-27 22:19:06 +01:00
constants Double-write file attachment to old "edge" storage and new "attachment" storage 2022-05-19 13:21:03 -07:00
controller Inline custom policy rules inside policy capability explanation dialogs 2019-09-12 09:40:50 -07:00
data Generate file attachment transactions for explicit Remarkup attachments on common edit pathways 2022-05-19 13:21:04 -07:00
draft Show yellow "draft" bubble in Audit 2017-01-16 10:28:59 -08:00
edges Remove file attachment edge types, including API access 2022-05-19 13:21:04 -07:00
editengine Fix PHP 8.1 "strlen(null)" exception which blocks rendering Conduit's dashboard.panel.edit page 2023-05-30 10:57:43 +02:00
editfield Fix PHP 8.1 "strlen(null)" exception which blocks rendering Conduit's dashboard.panel.edit page 2023-05-30 10:57:43 +02:00
editor Correct spelling mistakes 2023-05-27 22:19:06 +01:00
edittype Accept null via conduit.edit to unassign a task 2018-01-31 15:33:52 -08:00
engine Propagate the "ContextObject" to Remarkup rendering in timelines 2021-02-13 13:37:36 -08:00
engineextension Fix subtype extension support check 2021-08-20 18:49:35 -04:00
error Allow users to unset "Editor", tailor short error messages properly on settings forms 2016-06-05 14:03:02 -07:00
exception When users submit "editing" inlines, warn them that their inlines will be saved 2020-05-04 13:13:15 -07:00
feed Separate "feed" and "notifications" better, allow stories to appear in notifications only 2018-12-10 16:02:43 -08:00
herald Support "Subtype" in Herald 2019-09-12 14:34:06 -07:00
interface Allow inline comment storage objects to generate their own runtime objects 2020-05-07 15:57:49 -07:00
phid Allow ApplicationEditor forms to be reconfigured 2015-11-10 10:24:40 -08:00
query Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
replyhandler Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
response When users submit "editing" inlines, warn them that their inlines will be saved 2020-05-04 13:13:15 -07:00
storage PhabricatorModularTransactionType: fix regression 2023-05-12 21:37:41 +02:00
typeahead Support filtering feed transactions by object type 2019-05-21 12:39:10 -07:00
view Render all Removed Comments a little more docile 2023-04-06 14:46:35 +02:00
worker Cache user notification and message counts 2016-06-05 08:52:43 -07:00
xaction Fix incorrect construction of subtype map when validating "subtype" transactions against non-subtypable objects 2019-08-28 06:57:04 -07:00