1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-03 04:02:43 +01:00
phorge-phorge/src/applications/transactions/editengine
Andre Klapper 72fdf232b4 Fix PHP 8.1 "strlen(null)" exception which blocks rendering Conduit's dashboard.panel.edit page
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15425

Test Plan: Applied this change; afterwards `/conduit/method/dashboard.panel.edit/` correctly renders in browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15425

Differential Revision: https://we.phorge.it/D25257
2023-05-30 10:57:43 +02:00
..
__tests__ Add a "subtype" field to EditEngine forms 2017-03-02 04:16:27 -08:00
PhabricatorEditEngine.php Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Maniphest task creation page 2023-05-01 15:52:23 +02:00
PhabricatorEditEngineAPIMethod.php Fix PHP 8.1 "strlen(null)" exception which blocks rendering Conduit's dashboard.panel.edit page 2023-05-30 10:57:43 +02:00
PhabricatorEditEngineDefaultLock.php Allow task statuses to "lock" them, preventing additional comments and interactions 2017-03-02 16:57:10 -08:00
PhabricatorEditEngineLock.php Allow task statuses to "lock" them, preventing additional comments and interactions 2017-03-02 16:57:10 -08:00
PhabricatorEditEngineLockableInterface.php Allow task statuses to "lock" them, preventing additional comments and interactions 2017-03-02 16:57:10 -08:00
PhabricatorEditEngineMFAEngine.php Always require MFA to edit contact numbers 2019-01-23 14:19:56 -08:00
PhabricatorEditEngineMFAInterface.php Allow objects to be put in an "MFA required for all interactions" mode, and support "MFA required" statuses in Maniphest 2018-12-28 00:10:54 -08:00
PhabricatorEditEnginePageState.php Replace old hard-coded URI-based "changes saved" jank with new overgeneralized cookie-based "changes saved" jank 2020-04-19 09:04:31 -07:00
PhabricatorEditEngineSubtype.php Fix PHP 8.1 "strlen(null)" exception which blocks rendering list of Active/All projects 2023-05-01 15:55:42 +02:00
PhabricatorEditEngineSubtypeInterface.php Allow EditEngine forms for objects which support subtyping to have a subtype configured 2017-03-02 04:18:06 -08:00
PhabricatorEditEngineSubtypeMap.php Allow subtypes to specify "mutations", to control the behavior of the "Change Subtype" action 2019-09-12 16:17:02 -07:00
PhabricatorEditPage.php Split Repository EditEngine form into smaller pages 2016-05-02 08:28:38 -07:00