1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-23 13:08:18 +01:00
phorge-phorge/webroot/rsrc
epriestley 7b1b146620 Save, then restore scroll position in Chrome textareas on remarkup assist
Summary:
Fixes T10396. Seems like this has been around for a while (references from 2011):

http://stackoverflow.com/questions/4002312/chrome-resets-the-textarea-scroll-bar-scrolltop-when-focus-is-called
https://bugs.chromium.org/p/chromium/issues/detail?id=75072

Commenting out this `focus()` seemed to fix the issue locally, at the cost of not focusing.

Saving, focusing, then restoring seems to produce the correct behavior everywhere.

Test Plan:
  - In Safari, Firefox and Chrome, typed a ton of text into a remarkup area (more than the height of the area, so it has a scrollbar).
  - Selected some text near the top.
  - Clicked "B" to bold the text.
  - Scroll position remained the same in all browsers (previously: in Chrome, it changed).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10396

Differential Revision: https://secure.phabricator.com/D15313
2016-02-19 14:55:15 -08:00
..
css Move Diffusion ReadmeView to PHUIDocumentProView 2016-02-19 04:18:33 +00:00
externals Swap charts from gRaphael to D3 2016-02-01 10:36:59 -08:00
favicons Add mask-icon for Safari pinned tab 2015-11-22 13:04:06 -08:00
image Remove defunt project image choices 2016-01-19 08:50:59 -08:00
js Save, then restore scroll position in Chrome textareas on remarkup assist 2016-02-19 14:55:15 -08:00