revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 23:32:40 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 872bcd4487 Make limits and ranges work better with Calendar event queries 
Summary:
Fixes T8911. This corrects several issues which could crop up if a calendar event query matched more results than the query limit:

  - The desired order was not applied by the SearchEngine -- it applies the first builtin order instead. Provide a proper builtin order.
  - When we generate ghosts, we can't do limiting in the database because we may select and then immediately discard a large number of parent events which are outside of the query range.
    - For now, just don't limit results to get the behavior correct.
    - This may need to be refined eventually to improve performance.
  - When trimming events, we could trim parents and fail to generate ghosts from them. Separate parent events out first.
  - Try to simplify some logic.

Test Plan: An "Upcoming" dashboard panel with limit 10 and the main Calendar "Upcoming Events" UI now show the same results.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8911

Differential Revision: https://secure.phabricator.com/D16289
2016-07-13 15:39:00 -07:00
..
almanac Send forced mail on SSH key edits 2016-05-19 15:01:25 -07:00
aphlict Cache user notification and message counts 2016-06-05 08:52:43 -07:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Don't re-mention users for comment edits 2016-06-13 13:57:59 -07:00
auth Clean up redirect URIs for "Temporary Tokens" and "API Tokens" settings panels 2016-06-28 14:51:04 -07:00
badges Better destruction of PhameBlog, BadgesBadge 2016-06-27 18:24:23 -07:00
base Open "Help" menu links in a new window 2016-07-04 10:59:40 -07:00
cache Add --purge-user to bin/cache purge 2016-06-04 14:45:15 -07:00
calendar Make limits and ranges work better with Calendar event queries 2016-07-13 15:39:00 -07:00
celerity New Tokens 2016-07-01 07:12:34 -07:00
chatlog Update chatlog to newPage() 2016-04-02 13:20:55 -07:00
conduit Convert all remaining old tabs to new PHUITabGroupViews 2016-06-30 18:50:09 -07:00
config Raise explicit setup issues about PHP 7 2016-07-05 05:33:26 -07:00
conpherence Generate "stub" events earlier, so more infrastructure works with Calendar 2016-07-13 07:41:16 -07:00
console After toggling DarkConsole, force a user settings cache fill 2016-06-05 10:04:23 -07:00
countdown Fix new Countdown link 2016-06-07 20:13:08 -07:00
daemon Fix a fatal when viewing a daemon task with an invalid ID 2016-07-08 07:08:45 -07:00
dashboard Implement a "pro" EditEngine for dashboard panels 2016-07-03 15:07:36 -07:00
differential Fix mobile menu for files in Differential Changesets 2016-07-09 14:25:48 -07:00
diffusion In Git, only use "--find-copies-harder" on small diffs 2016-07-10 08:03:57 -07:00
diviner Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
doorkeeper Bridge GitHub users into Phabricator and attribute actions to them 2016-03-28 13:10:32 -07:00
draft/storage Fix EditEngine preview/draft for first comment on a task you didn't create 2015-12-05 09:57:45 -08:00
drydock Convert all remaining old tabs to new PHUITabGroupViews 2016-06-30 18:50:09 -07:00
fact Update Facts for newPage 2016-04-03 15:07:52 -07:00
feed Fix several issues with email-related global preferences 2016-06-14 12:35:31 -07:00
files Simplify "builtin file" management and recover from races 2016-07-11 09:25:34 -07:00
flag Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
fund Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
harbormaster Convert all remaining old tabs to new PHUITabGroupViews 2016-06-30 18:50:09 -07:00
help Update Help for newPage 2016-04-05 07:26:31 -07:00
herald Allow Herald text list fields to use "Exists" / "Does not exist" conditions 2016-06-21 15:27:43 -07:00
home Improve some settings-related performance 2016-06-05 10:32:23 -07:00
legalpad Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
lipsum Modularize content sources 2016-03-26 11:59:45 -07:00
macro Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
maniphest Render parent and child tasks in Maniphest with a graph trace 2016-07-01 10:41:07 -07:00
meta Give application actors in feed reasonable icons 2016-04-20 14:38:55 -07:00
metamta Convert all remaining old tabs to new PHUITabGroupViews 2016-06-30 18:50:09 -07:00
multimeter Add a cluster.read-only option 2016-04-09 13:40:47 -07:00
notification Strip timestamps from popup notification bubbles 2016-07-08 07:46:09 -07:00
nuance Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
oauthserver Formalize and fully modularize settings panel groups 2016-06-04 14:39:11 -07:00
owners Show more repository information in Owners path editing dropdown 2016-07-08 07:08:33 -07:00
passphrase Prevent locked credentials from being made accessible via conduit 2016-05-18 14:54:44 -07:00
paste add renderValue() in transactions 2016-07-08 16:59:25 -07:00
people In email, render dates with an explicit timezone offset 2016-07-13 08:32:37 -07:00
phame Update Phame documentation to reflect changes to the application 2016-07-06 18:43:06 -07:00
phid Convert Calendar to Modular Transactions 2016-07-13 07:46:33 -07:00
phlux Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
pholio Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
phortune Add print styles for Phortune carts 2016-06-08 07:52:18 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Moderize Phragment 2016-04-02 14:24:40 +00:00
phrequent Add a Phrequent curtain extension 2016-03-10 18:45:04 -08:00
phriction Make Phriction previews of the root document work correctly 2016-07-08 07:28:39 -07:00
phurl Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
policy Modernize "favorite project policies" setting 2016-06-04 14:42:11 -07:00
ponder Add Ponder Question mail create receiver 2016-06-08 14:48:20 -07:00
project Render browse results with global result style 2016-06-20 16:49:02 -07:00
releeph Update Releeph to new UI 2016-04-05 13:16:10 -07:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository Ignore unreachable commits when testing if a repository has imported 2016-07-11 09:23:08 -07:00
search By default, do not save queries when executing Conduit "*.search" calls 2016-07-10 08:04:11 -07:00
settings Fix ApplicationSearch URIs for Settings 2016-07-05 16:55:39 -07:00
slowvote Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
spaces Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
subscriptions Allow stacked comment actions to be explicitly ordered 2016-04-06 09:15:27 -07:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Two-for-one deal on typos 2016-05-18 09:53:39 -07:00
tokens More tokens 2016-07-03 18:32:40 -07:00
transactions In email, render dates with an explicit timezone offset 2016-07-13 08:32:37 -07:00
typeahead Push typehead browse result selector button down one <div> 2016-06-21 15:28:12 -07:00
uiexample Convert all remaining old tabs to new PHUITabGroupViews 2016-06-30 18:50:09 -07:00
xhprof Update XHProf for newPage 2016-04-04 08:40:49 -07:00