1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 05:50:55 +01:00
phorge-phorge/webroot/rsrc/js/application
epriestley 82be07315c Improve rendering of tokenizer tokens in Herald when editing rules
Summary:
Fixes T7848. @jasonfsmitty discussed an issue in great detail there and in D14359, and I completely missed it. Specifically:

  - If you save a "Change status to: Open" rule in Maniphest, and then edit it again, the token shows "Unknown Object (???)" instead of the correct token.
  - That's because loadHandles() has no idea what to do with the value "open", since it's not a real PHID.

The way we render tokenizer tokens in Herald is quite hacky right now. Fortunately, I wrote a //slightly// better way for EditEngine yesterday or the day before. Use the slightly better way to fix the issue with D14359.

This could still be better than it is, but the badness is mostly hidden now and can be cleaned up later without impacting anything.

Test Plan: Edited a Herald rule with projects and status changes, saw proper tokens.

Reviewers: chad

Reviewed By: chad

Subscribers: jasonfsmitty

Maniphest Tasks: T7848

Differential Revision: https://secure.phabricator.com/D14682
2015-12-05 11:20:07 -08:00
..
aphlict Merge branch 'master' into redesign-2015 2015-06-22 15:52:40 -07:00
auth Add Persona auth provider 2013-10-14 14:34:57 -07:00
calendar Show informative errors when attempting to set a recurrence end date on a non-recurring event. 2015-06-07 15:57:19 -07:00
config Fix custom field selector control in cases where the user doesn't edit anything 2015-05-25 05:34:23 -07:00
conpherence Remove Files Widget from Conpherence 2015-08-20 08:24:42 -07:00
countdown Define JavaScript functions before they are used 2014-12-30 02:53:32 -08:00
daemon Execute Maniphest batch edits in the background with a web UI progress bar 2015-06-23 13:36:16 -07:00
dashboard Fix various spelling mistakes 2014-07-13 00:45:33 +10:00
differential Show users what's wrong when they try to edit an inline with an editor already open 2015-09-10 11:36:38 -07:00
diffusion Make Diffusion "Last Modified" rendering less fragile 2015-10-07 07:32:27 -07:00
doorkeeper Various linter fixes. 2014-02-26 12:44:58 -08:00
drydock Show a more reasonable status element for pull requests 2015-10-21 11:28:26 -07:00
files Various linter fixes. 2014-02-26 12:44:58 -08:00
herald Improve rendering of tokenizer tokens in Herald when editing rules 2015-12-05 11:20:07 -08:00
maniphest Replace all Maniphest commenting code with EditEngine commenting code 2015-12-04 16:29:25 -08:00
owners Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
passphrase Rename Passphrase credential control JS 2015-03-02 13:01:00 -08:00
phame Use PHUIRemarkupPreviewView in Phame 2015-11-23 10:36:02 -08:00
pholio Quicksand and Pholio - make mock edit work 2015-05-07 10:42:07 -07:00
phortune Remove support for Balanced payments 2015-03-13 15:47:37 -07:00
policy Allow different policy rules for different types of objects 2015-06-13 15:44:03 -07:00
projects Conpherence + workboards - fix dragging behavior breaking on subsequent page loads 2015-05-12 11:37:55 -07:00
releeph Make scrolling happen relative to the main content frame 2015-01-25 08:42:40 -08:00
repository Symbol Search: Allow ctrl-click with no hover 2015-08-27 04:17:38 -07:00
search Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
slowvote Replace the primary scrollbar with a fake one to prepare for a persistent chat column 2015-01-23 13:29:15 -08:00
transactions Save stacked actions in drafts, not just comments 2015-12-04 16:29:43 -08:00
typeahead Implement viewer() and members(project) typeahead functions 2015-04-17 11:06:58 -07:00
uiexample Use window.confirm instead of confirm 2014-12-30 02:55:12 -08:00