epriestley bd0011076b Don't disrupt repository import chain when publishing is disabled ... Summary: Fixes T4736. Currently, we incorrectly skip the `writeImportStatusFlag()` call if publishing is disabled (the `herald-disabled`) check. This means we don't flag the commit as imported, and don't move the pipeline forward correctly. Instead, we only want to skip the owners stuff, not the pipeline stuff. Move that to a method. (Also fix a nearby TODO now that we have a permanent failure exception.) Test Plan: - Used `scripts/repository/reparse.php --owners ...` to execute this code, fiddled with things to hit both the disabled and enabled branches and verified the flag stuff is still reached. - Faked the exceptions and made sure they raise correctly. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4736 Differential Revision: https://secure.phabricator.com/D8715		2014-04-08 05:13:28 -07:00
..
arcanist/conduit
audit	Restore reply instructions to ApplicationTransaction email	2014-04-04 11:14:21 -07:00
auth	Update Google auth documentation to discuss "Google+ API" and new console URI	2014-03-25 13:36:47 -07:00
base	Make dialogs a little easier to use	2014-03-21 14:40:05 -07:00
cache	Minor, mark SERIALIZATION_PHP fields as BINARY in Lisk	2014-02-23 16:35:51 -08:00
calendar	Issue a proper 404 when trying to edit nonexistent events	2014-03-21 19:11:48 -07:00
chatlog	Various linter fixes.	2014-02-26 12:44:58 -08:00
conduit	Modernize documentation links	2014-03-17 15:01:31 -07:00
config	Make Maniphest task statuses user configurable	2014-03-25 14:05:36 -07:00
conpherence	Restore reply instructions to ApplicationTransaction email	2014-04-04 11:14:21 -07:00
countdown	[Countdown] fix undefined variable errors	2014-02-05 05:33:31 -08:00
daemon	Do not perform write in PhabricatorDaemonLogQuery by default	2014-01-21 14:04:12 -08:00
dashboard	Add edit/view plumbing for dashboards and panels	2014-02-03 10:52:15 -08:00
differential	Don't show 'needs review' on DifferentialObjects	2014-04-04 14:00:28 -07:00
diffusion	Diffusion - Warn users to explicitly provide PATH for SVN hosted repositories	2014-04-04 12:47:10 -07:00
diviner	Fix help menu links for folks with diviner uninstalled	2014-03-28 13:41:19 -07:00
doorkeeper	Make "JIRA Issues" field work better with noncredentialed accounts	2014-04-02 12:03:59 -07:00
draft/storage	Differential - add DifferentialDraft to track whether revisions have draft feedback or not	2014-02-18 16:25:16 -08:00
drydock	Set name parameter when saving file via Drydock	2014-04-03 09:21:36 -07:00
fact	Extend all "ManagementWorkflow" classes from a base class	2013-12-27 13:15:40 -08:00
feed	Include storyText in feed POST data	2014-04-06 11:48:39 -07:00
files	Modernize documentation links	2014-03-17 15:01:31 -07:00
flag	Make attention count yellow	2014-03-29 10:26:53 -07:00
harbormaster	Prevent buildable list in Harbormaster from breaking when container or buildables are missing	2014-03-25 17:35:49 -07:00
help	Fix help menu links for folks with diviner uninstalled	2014-03-28 13:41:19 -07:00
herald	Support CustomField in Herald, mostly	2014-04-03 18:43:49 -07:00
home	Fix Maniphest links w.r.t. new "status" data format	2014-03-28 12:59:09 -07:00
legalpad	Restore reply instructions to ApplicationTransaction email	2014-04-04 11:14:21 -07:00
lipsum	Use DifferentialRevisionEditor in lipsum	2014-03-11 13:02:00 -07:00
macro	Restore reply instructions to ApplicationTransaction email	2014-04-04 11:14:21 -07:00
mailinglists	Extract textual object list parsing from Differential	2014-03-07 17:44:44 -08:00
maniphest	Restore reply instructions to ApplicationTransaction email	2014-04-04 11:14:21 -07:00
meta	Various linter fixes.	2014-02-26 12:44:58 -08:00
metamta	Add original mail headers to the bottom of error mail	2014-04-06 07:57:03 -07:00
notification	Add a "Send Test Notification" button to make testing the server easier	2014-02-17 16:00:33 -08:00
nuance	Various linter fixes.	2014-02-26 12:44:58 -08:00
oauthserver	Use modern UI for OAuthServer details page	2014-03-18 15:39:45 -07:00
owners	Modernize documentation links	2014-03-17 15:01:31 -07:00
passphrase	Implement a "credential" standard custom field	2014-03-25 16:13:27 -07:00
paste	Maniphest Tasks + Project Boards - some polish	2014-03-04 17:01:33 -08:00
people	When we fail to process mail, tell the user about it	2014-04-03 18:43:18 -07:00
phame	Modernize documentation links	2014-03-17 15:01:31 -07:00
phid	Modernize OAuthServer PHIDs and Queries	2014-03-18 13:27:55 -07:00
phlux	Use "\z" instead of "$" to anchor validating regular expressions	2014-03-13 12:42:41 -07:00
pholio	Restore reply instructions to ApplicationTransaction email	2014-04-04 11:14:21 -07:00
phortune	Added some additional assertion methods.	2014-03-08 19:16:21 -08:00
phpast	Remove phpast.* Conduit methods	2014-03-12 11:30:22 -07:00
phragment	Various linter fixes.	2014-02-26 12:44:58 -08:00
phrequent	Various linter fixes.	2014-02-26 12:44:58 -08:00
phriction	Update Phriction History UI	2014-03-30 11:18:49 -07:00
policy	Added some additional assertion methods.	2014-03-08 19:16:21 -08:00
ponder	Maniphest Tasks + Project Boards - some polish	2014-03-04 17:01:33 -08:00
project	Make contextual matching of project monograms more liberal	2014-04-04 11:13:06 -07:00
releeph	Rename project -> product on edit/create UIs	2014-03-29 09:16:40 -07:00
remarkup/conduit	Support processing Remarkup in bulk with remarkup.processbulk Conduit method	2013-11-02 16:30:11 -07:00
repository	Don't disrupt repository import chain when publishing is disabled	2014-04-08 05:13:28 -07:00
search	Provide viewer to CustomFields in ApplicationSearch	2014-03-25 14:02:18 -07:00
settings	Add semi-generic rate limiting infrastructure	2014-04-03 11:22:38 -07:00
slowvote	Modernize documentation links	2014-03-17 15:01:31 -07:00
subscriptions	Show profile pictures in subscribers dialog	2014-03-19 19:29:48 -07:00
support/application	Whitelist allowed editor protocols	2014-03-17 13:00:37 -07:00
system	When we fail to process mail, tell the user about it	2014-04-03 18:43:18 -07:00
tokens	Include storyText in feed POST data	2014-04-06 11:48:39 -07:00
transactions	Include storyText in feed POST data	2014-04-06 11:48:39 -07:00
typeahead	Audit - add ability to add a package as an auditor	2014-04-04 12:25:03 -07:00
uiexample	Major timeline redesign	2014-03-27 14:24:31 -07:00
xhprof	Use JSON, not PHP serialization, for XHProf profiles.	2014-02-24 04:16:52 -08:00