mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-25 00:02:41 +01:00
894cd13a41
Summary: We had some null bytes appearing in strings from unit test results, which caused the PhutilRemarkupEngine to fail at properly generating html for it. Specifically, the string would get cut off at the null byte, and the closing </p> tag would never get added. The lack of this tag caused the dom for the rest of the page to end up inside a hidden td in the unit test results table. This is a horrible hack of a solution for this - it would be better to fix PhutilRemarkupEngine (and in the future, strip out null bytes in input in strings). Test Plan: load a differential revision and see content after the unittest results Reviewers: epriestley, vrana Reviewed By: vrana CC: aran, Korvin, rm Differential Revision: https://secure.phabricator.com/D5065 |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| application | ||
| conduit | ||
| config | ||
| constants | ||
| controller | ||
| data | ||
| editor | ||
| events | ||
| exception | ||
| field | ||
| parser | ||
| query | ||
| render | ||
| search | ||
| stats | ||
| storage | ||
| view | ||
| DifferentialReplyHandler.php | ||
| DifferentialTasksAttacher.php | ||