revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 17:28:51 +02:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 8d048f06ab Fix a Herald issue where testing commits against rules with revision-related conditions would fail 
Summary:
Fixes T11610. Clean up some sketchy old code from long ago.

If you had rules that use conditions like "Accepted revision exists" and ran them in the test console, we'd never load the "CommitData" and fatal.

Instead, load CommitData in `newTestAdapter()` and generally make these pathways a little more modern.

Test Plan:
  - Wrote an "Accepted Revision Exists" rule.
  - Ran a commit in the test console.
  - Before patch, got fatal from T11610.
  - After patch, got clean test result.
  - Also pushed a commit and reviewed the transcript to make sure the rule ran properly.

Reviewers: joshuaspence, chad

Reviewed By: chad

Maniphest Tasks: T11610

Differential Revision: https://secure.phabricator.com/D16522
2016-09-08 17:16:40 -07:00
..
almanac Fix getIcon calls in PHUIObjectListItem 2016-08-19 09:35:09 -07:00
aphlict Cache user notification and message counts 2016-06-05 08:52:43 -07:00
arcanist/conduit
audit Fix a Herald issue where testing commits against rules with revision-related conditions would fail 2016-09-08 17:16:40 -07:00
auth Add Slack authentication adapter 2016-09-06 15:50:37 +00:00
badges Better destruction of PhameBlog, BadgesBadge 2016-06-27 18:24:23 -07:00
base Removed all instances of getIconURI 2016-08-29 18:11:31 -04:00
cache Add --purge-user to bin/cache purge 2016-06-04 14:45:15 -07:00
calendar Respect "End Date" for recurring Calendar events in detail UI 2016-09-08 10:20:04 -07:00
celerity Add a few more high contrast CSS rules 2016-09-07 11:03:05 -07:00
chatlog Update chatlog to newPage() 2016-04-02 13:20:55 -07:00
conduit Throw when callers pass an invalid constraint to a "*.search" method 2016-09-07 09:07:53 -07:00
config Add a friendlier "in flight" error page 2016-09-07 06:59:48 -07:00
conpherence Always show a menu on durable column 2016-09-07 14:28:47 -07:00
console After toggling DarkConsole, force a user settings cache fill 2016-06-05 10:04:23 -07:00
countdown Fix new Countdown link 2016-06-07 20:13:08 -07:00
daemon Fix a fatal when viewing a daemon task with an invalid ID 2016-07-08 07:08:45 -07:00
dashboard Implement a "pro" EditEngine for dashboard panels 2016-07-03 15:07:36 -07:00
differential Fix a Herald issue where testing commits against rules with revision-related conditions would fail 2016-09-08 17:16:40 -07:00
diffusion Fix a Herald issue where testing commits against rules with revision-related conditions would fail 2016-09-08 17:16:40 -07:00
diviner Update Diviner for array-valued @doc-stuff return values from DocblockParser 2016-09-02 05:24:29 -07:00
doorkeeper Recover from a race when importing external objects (like JIRA issues) for the first time 2016-09-07 11:16:42 -07:00
draft/storage Clean up some log spam caused by races in VersionedDraft 2016-09-05 13:01:53 -07:00
drydock Fix getIcon calls in PHUIObjectListItem 2016-08-19 09:35:09 -07:00
fact Update Facts for newPage 2016-04-03 15:07:52 -07:00
feed Make "Core Applications" more reasonable 2016-08-12 07:57:59 -07:00
files Add a "--copy" flag to "bin/files migrate" 2016-09-06 13:53:59 -07:00
flag
fund Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
guides Use new Guide layout in Config->Welcome 2016-09-03 07:32:22 -07:00
harbormaster Provide a workflow to restart Harbormaster builds 2016-09-02 13:32:02 +00:00
help Update Help for newPage 2016-04-05 07:26:31 -07:00
herald Fix a Herald issue where testing commits against rules with revision-related conditions would fail 2016-09-08 17:16:40 -07:00
home Use new Guide layout in Config->Welcome 2016-09-03 07:32:22 -07:00
legalpad Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
lipsum Modularize content sources 2016-03-26 11:59:45 -07:00
macro Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
maniphest Add setup checks for unused homepage options 2016-08-25 12:08:02 -07:00
meta Check if app is installed for user before displying 2016-09-07 22:42:20 -04:00
metamta Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
multimeter Add a cluster.read-only option 2016-04-09 13:40:47 -07:00
notification Strip timestamps from popup notification bubbles 2016-07-08 07:46:09 -07:00
nuance Fix some more setIcon() issues 2016-08-31 10:00:03 -07:00
oauthserver Formalize and fully modularize settings panel groups 2016-06-04 14:39:11 -07:00
owners Correct spelling of "therefore" 2016-08-30 14:09:05 -07:00
packages Make "Core Applications" more reasonable 2016-08-12 07:57:59 -07:00
passphrase Prevent locked credentials from being made accessible via conduit 2016-05-18 14:54:44 -07:00
paste Fix the feed line items for autodetect paste languages 2016-08-29 22:29:29 -04:00
people Update People for handleRequest 2016-08-25 13:39:59 -04:00
phame Remove overbearing policy checks in Phame 2016-09-05 12:10:45 -07:00
phid Simplify how tag lists manage their handles 2016-08-19 11:09:40 -07:00
phlux Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
pholio Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
phortune Implement PhabricatorApplicationTransactionInterface on PhortunePaymentProviderConfig 2016-08-30 09:18:10 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Moderize Phragment 2016-04-02 14:24:40 +00:00
phrequent Redesign Config Application 2016-08-29 15:49:49 -07:00
phriction Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
phurl Start actually showing the phurl urls to users 2016-08-29 22:49:01 -04:00
policy Allow *.search Conduit API methods to have data bulk-loaded by extensions 2016-07-31 11:15:18 -07:00
ponder Make "Core Applications" more reasonable 2016-08-12 07:57:59 -07:00
project Super Pro Dexule fix for project icon timeline 2016-09-07 10:48:06 -07:00
releeph Make "Core Applications" more reasonable 2016-08-12 07:57:59 -07:00
remarkup/conduit
repository Add a summary view of all repository errors to the repository cluster screen 2016-08-30 09:21:12 -07:00
search Throw when callers pass an invalid constraint to a "*.search" method 2016-09-07 09:07:53 -07:00
settings Added - to the whitelist for CSS rules 2016-09-07 23:44:11 -04:00
slowvote Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
spaces Allow *.search Conduit API methods to have data bulk-loaded by extensions 2016-07-31 11:15:18 -07:00
subscriptions Allow stacked comment actions to be explicitly ordered 2016-04-06 09:15:27 -07:00
support/application
system Redesign Config Application 2016-08-29 15:49:49 -07:00
tokens More tokens 2016-07-03 18:32:40 -07:00
transactions Support object mentions in Calendar Event descriptions 2016-08-31 15:33:45 -07:00
typeahead Push typehead browse result selector button down one <div> 2016-06-21 15:28:12 -07:00
uiexample Add setBackground to PHUIIconView 2016-08-19 13:19:53 -07:00
xhprof Removing deprecated method calls 2016-08-23 03:26:34 -05:00