1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 15:52:41 +01:00
phorge-phorge/src/applications/harbormaster
epriestley 39cf013472 Add objectPHID keys to Harbormaster task schedulers
Summary:
Fixes T9816. It's currently hard to hunt down some particulars in the worker queue if things go awry in Harbormaster.

Supplement the queue with `objectPHID` keys so we can hunt tasks down more easily if the issues in T9816 continue.

Test Plan:
```
mysql> select * from worker_archivetask order by id desc limit 30;
+--------+------------------------------------------------+-----------------------------------+--------------+--------------+--------+--------+----------+-------------+--------------+----------+--------------------------------+
| id     | taskClass                                      | leaseOwner                        | leaseExpires | failureCount | dataID | result | duration | dateCreated | dateModified | priority | objectPHID                     |
+--------+------------------------------------------------+-----------------------------------+--------------+--------------+--------+--------+----------+-------------+--------------+----------+--------------------------------+
| 496024 | HarbormasterTargetWorker                       | 8514:1448232248:Orbital.local:3   |   1448318648 |            0 | 311880 |      0 |   233758 |  1448232248 |   1448232248 |     2000 | PHID-HMBT-thq4oof4byllmbc4q3tt |
| 496023 | PhabricatorApplicationTransactionPublishWorker | 8514:1448232247:Orbital.local:1   |   1448239447 |            0 | 311879 |      0 |    53731 |  1448232247 |   1448232247 |     1000 | PHID-HMBD-i6zo2ltc73rre7o54s7v |
| 496022 | HarbormasterBuildWorker                        | 8514:1448232247:Orbital.local:2   |   1448239447 |            0 | 311878 |      0 |    30736 |  1448232248 |   1448232248 |     2000 | PHID-HMBD-i6zo2ltc73rre7o54s7v |
...
```

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9816

Differential Revision: https://secure.phabricator.com/D14541
2015-11-23 05:58:54 -08:00
..
__tests__ Add "Autoplans" to Harbormaster 2015-06-21 09:04:21 -07:00
application Give Harbormaster build steps a "View" page 2015-10-26 12:38:32 -07:00
artifact In Harbormaster, make sure artifacts are destroyed even if a build is aborted 2015-10-05 05:58:53 -07:00
autoplan Give "Arcanist Client Results" a more clear name 2015-09-09 19:18:08 -07:00
capability Give Harbormaster Build Plans real policies 2015-10-26 12:38:21 -07:00
conduit Add objectPHID keys to Harbormaster task schedulers 2015-11-23 05:58:54 -08:00
config Add getGroup to ConfigOptions 2015-02-09 13:10:56 -08:00
controller add initiator.phid parameter to HM builds 2015-11-04 18:32:18 +00:00
customfield Use Drydock authorizations when acquiring leases 2015-10-12 17:02:35 -07:00
editor Add objectPHID keys to Harbormaster task schedulers 2015-11-23 05:58:54 -08:00
engine Add objectPHID keys to Harbormaster task schedulers 2015-11-23 05:58:54 -08:00
event Show external build links in applications 2015-08-15 07:29:26 -07:00
exception Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
future Allow Harbormaster to run commands on Drydock working copies 2015-09-25 10:43:32 -07:00
herald add initiator.phid parameter to HM builds 2015-11-04 18:32:18 +00:00
interface Move build variables into HarbormasterBuildableInterface 2014-06-20 12:58:23 +10:00
management add initiator.phid parameter to HM builds 2015-11-04 18:32:18 +00:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
query Show external build links in applications 2015-08-15 07:29:26 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
step Fix an issue with incorrect authorization handling in Working Copy build steps 2015-10-30 16:02:35 +00:00
stepgroup Put Drydock build steps into their own group in Harbormaster 2015-10-05 15:59:35 -07:00
storage Add objectPHID keys to Harbormaster task schedulers 2015-11-23 05:58:54 -08:00
typeahead Give typeahead browse dialogs sensible titles 2015-04-20 10:06:23 -07:00
view Remove leftover code for "postponed" lint and unit status 2015-08-29 22:19:28 +10:00
worker Allow Harbormaster build plans to request additional working copies 2015-09-28 17:57:41 -07:00