revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 15:52:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 8ec413b972 Clean up "ids" and "phids" handling in SearchEngines 
Summary:
Ref T9964. I added several hacks to get these working. Clean them up and pull this into a proper extension.

The behavior in the web UI is:

  - they work in all applications; but
  - they only show up in the UI if a value is specified.

So if you visit `/view/?ids=1,2` you get the field, but normally it's not present. We could refine this later. I'm going to add documentation about how to prefill these forms regardless, which should make this discoverable by reading the documentation.

There's one teensey weensey hack: in the API, I push these fields to the top of the table. That one feels OK, since it's purely a convenience/display adjustment.

Test Plan: Queried by IDs, reviewed docs.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9964

Differential Revision: https://secure.phabricator.com/D14769
2015-12-14 04:24:54 -08:00
..
almanac Modernize Badges 2015-11-28 15:04:14 -08:00
aphlict Update "should not run as root" message 2015-10-31 11:20:23 +00:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Make notification counts properly translatable 2015-12-03 07:06:39 -08:00
auth Write 500 words on how to restart webservers 2015-12-02 09:16:10 -08:00
badges Add PhabricatorBadgeArchiveController 2015-12-09 13:29:03 -08:00
base Clean up some EditEngine meta-policies 2015-12-07 15:40:31 -08:00
cache Write 500 words on how to restart webservers 2015-12-02 09:16:10 -08:00
calendar Linter fixes 2015-12-03 07:44:23 +11:00
celerity Add mask-icon for Safari pinned tab 2015-11-22 13:04:06 -08:00
chatlog Update Chatlog for handleRequest 2015-07-31 09:14:44 -07:00
conduit Clean up "ids" and "phids" handling in SearchEngines 2015-12-14 04:24:54 -08:00
config Drop "-pro" suffix and "editpro" URIs for EditEngine in Maniphest 2015-12-08 17:56:59 -08:00
conpherence Extract PHIDs from transactions later, fixing Paste extraction/attachment 2015-11-17 08:37:07 -08:00
console Push construction of routing maps into Sites 2015-08-31 04:01:01 -07:00
countdown Modernize Countdown 2015-11-30 07:11:03 -08:00
daemon Remove daemon envHash and envInfo 2015-11-11 08:54:45 +11:00
dashboard Add DashboardArchiveController 2015-12-09 12:29:59 -08:00
differential When arc has sent target branch data up after D14736, use it in the UI and "Land Revision" 2015-12-10 15:24:38 -08:00
diffusion Add a DiffusionRefDatasource for typeahead'ing branches, tags, bookmarks and refs 2015-12-10 14:21:24 -08:00
diviner Linter fixes 2015-12-03 07:44:23 +11:00
doorkeeper JIRA Integration: Link and/or Comment 2015-11-12 19:30:43 +00:00
draft/storage Fix EditEngine preview/draft for first comment on a task you didn't create 2015-12-05 09:57:45 -08:00
drydock Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
fact Update Facts for handleRequest 2015-07-27 09:12:35 -07:00
feed Remove some low-hanging buildStandardPageResponse() methods 2015-11-03 10:11:36 -08:00
files Linter fixes 2015-12-03 07:44:23 +11:00
flag Make notification counts properly translatable 2015-12-03 07:06:39 -08:00
fund Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
harbormaster Add objectPHID keys to Harbormaster task schedulers 2015-11-23 05:58:54 -08:00
help Remove some low-hanging buildStandardPageResponse() methods 2015-11-03 10:11:36 -08:00
herald Allow "Assign task" Herald Action in Maniphest to accept "None" to unassign 2015-12-05 12:39:45 -08:00
home Drop "Quick Create" header from quick create menu 2015-12-07 13:43:54 -08:00
legalpad Remove pro-white-background, re-style PHUIDocumentViewPro 2015-11-28 07:20:55 -08:00
lipsum Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
macro Allow any {icon} to spin 2015-10-30 16:02:19 +00:00
maniphest Clean up "ids" and "phids" handling in SearchEngines 2015-12-14 04:24:54 -08:00
meta Make notification counts properly translatable 2015-12-03 07:06:39 -08:00
metamta Fix a potentially lax hash comparison 2015-11-10 10:22:25 -08:00
multimeter Various translation improvements 2015-11-03 07:02:46 +11:00
notification Remove some low-hanging buildStandardPageResponse() methods 2015-11-03 10:11:36 -08:00
nuance Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
oauthserver Linter fixes 2015-12-03 07:44:23 +11:00
owners Flesh out Conduit parmeter types for maniphest.search 2015-12-14 04:24:01 -08:00
passphrase Introduce PHUIRemarkupView, a sane way to work with Remarkup 2015-10-15 10:20:19 -07:00
paste Flesh out Conduit types for Paste search fields 2015-12-14 04:23:28 -08:00
people Add basic typechecking support to Conduit 2015-12-14 04:21:39 -08:00
phame Add Drafts to PhameHome 2015-12-12 13:26:18 -08:00
phid Provide formal Users/Projects/Mailable fields for EditEngine 2015-11-04 12:05:41 -08:00
phlux Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
pholio Add PholioMockArchiveController 2015-12-09 13:20:25 -08:00
phortune Remove the PhortuneNotImplementedException class 2015-11-12 06:33:39 +11:00
phpast Rename XHPAST database 2015-11-14 21:41:28 +11:00
phragment Various translation improvements 2015-11-03 07:02:46 +11:00
phrequent Make notification counts properly translatable 2015-12-03 07:06:39 -08:00
phriction Remove pro-white-background, re-style PHUIDocumentViewPro 2015-11-28 07:20:55 -08:00
phurl Allow Phurl short aliases to accept trailing / characters 2015-12-11 10:28:19 -08:00
policy Clean up "*.search" API method documentation pages 2015-12-14 04:24:39 -08:00
ponder Update Ponder for Remarkup in Feed 2015-12-05 14:46:37 -08:00
project Clean up "*.search" API method documentation pages 2015-12-14 04:24:39 -08:00
releeph Linter fixes 2015-12-03 07:44:23 +11:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository Throw CommandException instead of Exception after git fetch failure in repository updates 2015-12-11 16:53:29 -08:00
search Clean up "ids" and "phids" handling in SearchEngines 2015-12-14 04:24:54 -08:00
settings Remove Certificate page 2015-11-04 06:35:22 +00:00
slowvote Modernize Slowvote, fix Badges mobile menu 2015-11-30 12:58:11 -08:00
spaces Clean up "*.search" API method documentation pages 2015-12-14 04:24:39 -08:00
subscriptions Clean up "*.search" API method documentation pages 2015-12-14 04:24:39 -08:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Permanently destroy Almanac properties with the destruction engine 2015-11-15 20:58:50 +00:00
tokens Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
transactions Give ConduitAPIMethod->getMethodDescription() access to a real Viewer 2015-12-14 04:20:11 -08:00
typeahead Save stacked actions in drafts, not just comments 2015-12-04 16:29:43 -08:00
uiexample More ActionPanel colors, hardening 2015-09-16 09:22:31 -07:00
xhprof Update XHProf for handleRequest 2015-08-01 15:41:57 -07:00