1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 18:32:41 +01:00
phorge-phorge/src/applications/herald
epriestley 03c6bf0d09 Make Herald less ambitious about resolving repositories for revisions
Summary:
Fixes T4636. If a user manually deletes a "repository" setting from a revision, Herald attempts to resolve it. Instead, Herald should now just trust Differential. Generally, the new logic is:

  - When diffs are created, figure out repository information.
  - When revisions are updated, copy info from diffs.
  - Everywhere else, just trust the revision field.

Test Plan:
  - Created revisions.
  - Used Herald to dry-run revisions before and after a manual edit to remove the repository setting.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4636

Differential Revision: https://secure.phabricator.com/D8576
2014-03-21 14:39:56 -07:00
..
adapter Make Herald less ambitious about resolving repositories for revisions 2014-03-21 14:39:56 -07:00
application Modernize documentation links 2014-03-17 15:01:31 -07:00
capability Remove the "create rules" Herald capability 2013-10-09 13:55:44 -07:00
config Lay most groundwork for Herald object rules 2013-12-27 13:17:10 -08:00
controller Fail more gracefully when rendering transcripts if handle is missing 2014-03-17 15:02:10 -07:00
editor Allow Herald rules to be disabled, instead of deleted 2013-10-06 17:10:29 -07:00
engine Various linter fixes. 2014-02-26 12:44:58 -08:00
garbagecollector Modularize the Garbage Collector 2014-01-15 10:02:24 -08:00
phid Give Herald rules a standard "Hnnn" object name 2013-12-18 12:00:18 -08:00
query Herald - add application search for transcripts 2014-02-21 12:51:25 -08:00
remarkup Give Herald rules a standard "Hnnn" object name 2013-12-18 12:00:18 -08:00
storage Add "Send an email" action to Herald for Maniphest 2014-03-14 11:52:31 -07:00
view Move PhabricatorObjectItem to PHUIObjectItem, add 'plain' setting for lists. 2013-09-09 14:14:34 -07:00