1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 17:32:41 +01:00
phorge-phorge/src/applications/herald/adapter
epriestley 03c6bf0d09 Make Herald less ambitious about resolving repositories for revisions
Summary:
Fixes T4636. If a user manually deletes a "repository" setting from a revision, Herald attempts to resolve it. Instead, Herald should now just trust Differential. Generally, the new logic is:

  - When diffs are created, figure out repository information.
  - When revisions are updated, copy info from diffs.
  - Everywhere else, just trust the revision field.

Test Plan:
  - Created revisions.
  - Used Herald to dry-run revisions before and after a manual edit to remove the repository setting.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4636

Differential Revision: https://secure.phabricator.com/D8576
2014-03-21 14:39:56 -07:00
..
HeraldAdapter.php Add "pusher is committer" to Herald as a pre-commit rule 2014-03-12 15:24:33 -07:00
HeraldCommitAdapter.php Clean up various pieces of dead/obsolete Differential code 2014-03-11 13:02:19 -07:00
HeraldDifferentialRevisionAdapter.php Make Herald less ambitious about resolving repositories for revisions 2014-03-21 14:39:56 -07:00
HeraldManiphestTaskAdapter.php Add "Send an email" action to Herald for Maniphest 2014-03-14 11:52:31 -07:00
HeraldPholioMockAdapter.php Herald - unleash some recursive madness! 2014-02-06 12:43:36 -08:00