1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 23:02:42 +01:00
phorge-phorge/webroot/rsrc/css
epriestley 90d0f8ac6c Revert changes to Diffusion blame view
Summary:
Ref PHI174. This reverts most of these changes:

- 37843127e9 / D18481
- 94cad30ac3 / D18474
- 12ae08b6b1 / D18473
- 0a01334172 / D18462
- ac91ab1ef9 / D18452

These changes made the Diffusion blame view very similar to GitHub's blame view. See D18452 for a before/after of the bulk of these changes; the other revisions are bugfixes.

I think this was generally a step backward, and not motivated by solving a specific problem. I've found the new UI less usable than the old one, and at least one install (see PHI174) also has.

In particular, the revision/commit titles are very bulky and not terribly useful; the date column also isn't terribly useful; the "age" color actually IS pretty useful and was heavily de-emphasized.

I've kept one bugfix here (missing `'a'` tag type) and kept the upgraded icon for "Skip Past This Commit".

I'm going to follow this up with some additional changes:

  - Show a small author profile icon, similar to GitHub, to address PHI174 more directly.
  - Try a zebra-stripe on blocks of rows to make it more clear where changes affected by a particular commit begin and end.
  - Try a hue shift, not just a brightness/saturation shift, to make the "age" color more distinct.
  - Try computing colors as even steps, not based purely on age. Currently, if a file has one long-distant commit and several recent commits, all the recent ones show up as very bright green. I think this would probably be more useful if they were distributed more evenly across the available color bands.

Test Plan:
Viewed blame views in Diffusion, saw a more compact UI similar to the old UI.

{F5251019}

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18746
2017-10-31 11:54:47 -07:00
..
aphront Mobile layouts for Diffusion 2017-08-30 12:28:00 -07:00
application Revert changes to Diffusion blame view 2017-10-31 11:54:47 -07:00
core Make PHUITwoColumnView a little more printable 2017-09-25 19:56:22 +00:00
diviner Lots of little fixes for Dark Mode (Experimental) 2017-07-19 14:41:23 -07:00
font Remove "Aleo" as specialized font for headers 2017-03-22 09:57:00 -07:00
layout Add an Experimental Dark Mode to Phabricator 2017-07-18 06:44:32 -07:00
phui Fix spelling 2017-10-09 10:48:04 -07:00
syntax Generate syntax highlighting CSS from a reusable map 2016-05-05 02:50:48 -07:00
sprite-login.css Uh, update Phabricator login image 2017-08-11 13:37:26 -07:00
sprite-tokens.css More tokens 2016-07-03 18:32:40 -07:00