revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 9125095587 Distinguish between empty and unparsed commits in Diffusion 
Summary:
Fixes T3416. Fixes T1733.

  - Adds a flag to the commit table showing whether or not we have parsed it.
  - The flag is set to `0` initially when the commit is discovered.
  - The flag is set to `1` when the changes are parsed.
  - The UI can now use the flag to distinguish between "empty commit" and "commit which we haven't imported changes for yet".
  - Simplify rendering code a little bit.
  - Fix an issue with the Message parser for empty commits.
  - There's a key on the flag so we can do `SELECT * FROM repository_commit WHERE repositoryID = %d AND importStatus = 0 LIMIT 1` soon, to determine if a repository is fully imported or not. This will let us improve the UI (Ref T776, Ref T3217).

Test Plan:
  - Ran `bin/storage upgrade -f`.
  - Created an empty commit.
  - Without the daemons running, ran `bin/repository pull GTEST` and `bin/repository discover GTEST`.
  - Viewed web UI to get the first screenshot ("Still Importing...").
  - Ran the message and change steps with `scripts/repository/reparse.php`.
  - Viewed web UI to get the second screenshot ("Empty Commit").

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T776, T1733, T3416, T3217

Differential Revision: https://secure.phabricator.com/D7428
2013-10-29 15:32:41 -07:00
..
arcanist/conduit Move Conduit methods inside applications 2012-12-21 12:21:59 -08:00
audit Make event-triggered actions more aware of application access 2013-10-21 17:00:50 -07:00
auth Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
base Accept and route VCS HTTP requests 2013-10-29 15:32:40 -07:00
cache Provide 'bin/cache', for managing caches 2013-05-20 10:16:35 -07:00
calendar Move PHUIFormBoxView to PHUIObjectBoxView 2013-09-25 11:23:29 -07:00
chatlog Fix chatlog application query integration 2013-10-22 13:47:47 -07:00
conduit Prepare to route VCS connections through SSH 2013-10-29 15:32:40 -07:00
config Enable "SSH Keys" auth panel unconditionally 2013-10-29 15:32:41 -07:00
conpherence Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
countdown Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
daemon Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
differential Add filter by object ability to flag query 2013-10-25 12:52:00 -07:00
diffusion Distinguish between empty and unparsed commits in Diffusion 2013-10-29 15:32:41 -07:00
directory/controller Hide Audit information on Home when the application is uninstalled 2013-10-09 15:25:03 -07:00
diviner Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
doorkeeper Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
draft/storage Add draft support to ApplicationTransactions 2012-12-21 05:57:14 -08:00
drydock PHUIPropertyListView 2013-10-11 07:53:56 -07:00
fact Convert AphrontTableView to safe HTML 2013-02-09 15:11:38 -08:00
feed Move Project transaction storage to modern tables 2013-10-22 13:49:28 -07:00
files Add filter by object ability to flag query 2013-10-25 12:52:00 -07:00
flag Work around a bug in PHP 5.3-ish with abstract methods in interfaces 2013-10-25 15:58:17 -07:00
harbormaster Harbormaster v(-2) 2013-10-22 15:01:06 -07:00
help/controller Make Differential views capability-sensitive 2013-09-26 18:45:04 -07:00
herald Add filter by object ability to flag query 2013-10-25 12:52:00 -07:00
legalpad Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
lipsum Kill PhabricatorObjectDataHandle 2013-09-11 12:27:28 -07:00
macro Add filter by object ability to flag query 2013-10-25 12:52:00 -07:00
mailinglists Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
maniphest Add filter by object ability to flag query 2013-10-25 12:52:00 -07:00
meta Update Apps Installed icons to match Projects. 2013-10-23 13:28:47 -07:00
metamta Fix "Manage herald rules" link by removing it 2013-10-21 16:58:56 -07:00
notification Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
oauthserver Initialize used variable 2013-07-09 21:55:27 -07:00
owners Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
paste Add filter by object ability to flag query 2013-10-25 12:52:00 -07:00
people Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
phame Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
phid Work around a bug in PHP 5.3-ish with abstract methods in interfaces 2013-10-25 15:58:17 -07:00
phlux Add filter by object ability to flag query 2013-10-25 12:52:00 -07:00
pholio Add filter by object ability to flag query 2013-10-25 12:52:00 -07:00
phortune Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
phpast Move PHUIFormBoxView to PHUIObjectBoxView 2013-09-25 11:23:29 -07:00
phrequent Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
phriction Add filter by object ability to flag query 2013-10-25 12:52:00 -07:00
policy Work around a bug in PHP 5.3-ish with abstract methods in interfaces 2013-10-25 15:58:17 -07:00
ponder Add filter by object ability to flag query 2013-10-25 12:52:00 -07:00
project Add filter by object ability to flag query 2013-10-25 12:52:00 -07:00
releeph Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
remarkup/conduit Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
repository Distinguish between empty and unparsed commits in Diffusion 2013-10-29 15:32:41 -07:00
search Add search app icon 2013-10-23 11:30:52 -07:00
settings Enable "SSH Keys" auth panel unconditionally 2013-10-29 15:32:41 -07:00
slowvote Add filter by object ability to flag query 2013-10-25 12:52:00 -07:00
subscriptions Tie application event listeners to the applications they listen for 2013-10-21 17:00:21 -07:00
system Add a user-accessible hook for dumping debug code into an install 2013-03-04 13:45:51 -08:00
tokens Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
transactions Add project history and title strings 2013-10-22 13:49:37 -07:00
typeahead Remove ProjectProfile->loadProfileImageURI() 2013-10-06 17:07:43 -07:00
uiexample PHUIInfoPanel 2013-10-25 11:09:06 -07:00
xhprof Make most file reads policy-aware 2013-09-30 09:38:13 -07:00