1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/people
epriestley 2a5c987c71 Lock policy queries to their applications
Summary:
While we mostly have reasonable effective object accessibility when you lock a user out of an application, it's primarily enforced at the controller level. Users can still, e.g., load the handles of objects they can't actually see. Instead, lock the queries to the applications so that you can, e.g., never load a revision if you don't have access to Differential.

This has several parts:

  - For PolicyAware queries, provide an application class name method.
  - If the query specifies a class name and the user doesn't have permission to use it, fail the entire query unconditionally.
  - For handles, simplify query construction and count all the PHIDs as "restricted" so we get a UI full of "restricted" instead of "unknown" handles.

Test Plan:
  - Added a unit test to verify I got all the class names right.
  - Browsed around, logged in/out as a normal user with public policies on and off.
  - Browsed around, logged in/out as a restricted user with public policies on and off. With restrictions, saw all traces of restricted apps removed or restricted.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7367
2013-10-21 17:20:27 -07:00
..
application Modernize email verification page 2013-07-10 18:53:09 -07:00
conduit Implement ApplicationSearch in People 2013-05-31 10:51:20 -07:00
config Support configuration-driven custom fields 2013-08-14 12:33:53 -07:00
controller PHUIPropertyListView 2013-10-11 07:53:56 -07:00
customfield Integrate ApplicationSearch with CustomField 2013-09-16 13:44:34 -07:00
editor Migrate PhabricatorUserLDAPInfo to PhabricatorExternalAccount 2013-06-16 09:55:55 -07:00
event Tie application event listeners to the applications they listen for 2013-10-21 17:00:21 -07:00
exception Delete license headers from files 2012-11-05 11:16:51 -08:00
lipsum Fixed Task Generation 2013-04-24 18:17:31 -07:00
phid Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
query Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
remarkup Implement ApplicationSearch in People 2013-05-31 10:51:20 -07:00
search Move PhabricatorUser to new phid stuff 2013-07-26 14:05:19 -07:00
storage Make PhabricatorPolicyInterface require a getPHID() method 2013-10-14 14:35:47 -07:00