1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 11:22:40 +01:00
phorge-phorge/src/applications/transactions
epriestley 91a78db99b Support "Assign To" in Maniphest bulk editor
Summary:
Ref T13025. See PHI173. This supports the "Assign to" field in the new editor.

This is very slightly funky: to unassign tasks, you need to leave the field blank. I have half a diff to fix this, but the way the `none()` token works in the default datasource is odd so it needs a separate datasource. I'm punting on this for now since it works, at least, and isn't //completely// unreasonable.

This also simplifies some EditEngine stuff a little. Notably:

  - I reorganized EditType construction slightly so subclasses can copy/paste a little bit less.
  - EditType had `field` and `editField` properties which had the same values. I canonicalized on `editField` and made this value set a little more automatically.

Test Plan: Used bulk editor to reassign some tasks. By leaving the field blank, unassigned tasks.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13025

Differential Revision: https://secure.phabricator.com/D18874
2018-01-19 12:48:41 -08:00
..
application Allow EditEngine forms for objects which support subtyping to have a subtype configured 2017-03-02 04:18:06 -08:00
bulk Restore "Tags" and "Subscribers" edit capabilities to Maniphest bulk editor 2018-01-19 12:47:10 -08:00
commentaction When accepting revisions, allow users to accept on behalf of a subset of reviewers 2017-03-22 14:25:04 -07:00
conduit Provide some more detailed information about inline comments in "transaction.search" 2017-08-24 15:26:50 -07:00
constants When an object which supports subtypes is created, set its subtype to the creating form's subtype 2017-03-02 04:18:23 -08:00
controller Remove duplicate "Change Default Values" action in form editing workflow 2017-03-22 09:50:38 -07:00
data Don't re-mention users for comment edits 2016-06-13 13:57:59 -07:00
draft Show yellow "draft" bubble in Audit 2017-01-16 10:28:59 -08:00
edges Add a generic "edge.search" method 2017-03-04 15:26:29 -08:00
editengine Support "Assign To" in Maniphest bulk editor 2018-01-19 12:48:41 -08:00
editfield Support "Assign To" in Maniphest bulk editor 2018-01-19 12:48:41 -08:00
editor Fix a minor/harmless race with feed publishers in certain draft states 2018-01-04 08:14:55 -08:00
edittype Support "Assign To" in Maniphest bulk editor 2018-01-19 12:48:41 -08:00
engineextension Restore bulk edit support for remarkup fields (description, add comment) 2018-01-19 12:45:34 -08:00
error Allow users to unset "Editor", tailor short error messages properly on settings forms 2016-06-05 14:03:02 -07:00
exception Mark some strings for translation 2015-06-09 23:06:52 +10:00
feed Add AuthorHref to feed story images 2017-02-07 10:09:00 -08:00
interface Transactions - adding willRenderTimeline to handle tricky cases 2014-12-04 13:58:52 -08:00
phid Allow ApplicationEditor forms to be reconfigured 2015-11-10 10:24:40 -08:00
query Fix transaction queries using withComments() for transactions with no comments 2017-10-02 09:09:53 -07:00
replyhandler Modularize content sources 2016-03-26 11:59:45 -07:00
response Make inline comment preview and submission mostly work on EditEngine 2016-12-31 10:10:29 -08:00
storage Fix an issue where "Close Revision" did not appear in the UI 2017-08-29 09:58:48 -07:00
typeahead Don't allow forms which can't create objects to be added to profile menus 2017-02-16 15:45:11 -08:00
view Use Log In vs. Login when it's a verb 2017-08-02 12:26:47 -07:00
worker Cache user notification and message counts 2016-06-05 08:52:43 -07:00
xaction Modularize application transactions in Paste, mostly 2016-06-14 06:13:28 -07:00