1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 11:22:40 +01:00
phorge-phorge/src/applications/transactions/query
epriestley cd14194a32 Fix transaction queries using withComments() for transactions with no comments
Summary:
See <https://discourse.phabricator-community.org/t/daemons-tasks-crashing-in-a-loop-during-reindex/506/1>. Some object types (for example, Passphrase Credentials) support indexing but not commenting.

Make `withComments(...)` work properly if the transaction type does not support comments.

Test Plan:
Indexed a credential (no comments) and a revision (comments) with `bin/search index --trace ...`.

Before, credential fataled.

After, credetial succeeds, and skips the transaction query.

Before and after, the revision queries the transaction table.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18667
2017-10-02 09:09:53 -07:00
..
PhabricatorApplicationTransactionCommentQuery.php Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery 2015-04-20 10:06:09 -07:00
PhabricatorApplicationTransactionQuery.php Fix transaction queries using withComments() for transactions with no comments 2017-10-02 09:09:53 -07:00
PhabricatorApplicationTransactionTemplatedCommentQuery.php Prepare TransactionCommentQuery for extension 2015-03-09 14:11:18 -07:00
PhabricatorEditEngineConfigurationQuery.php When editing a subtyped object, use edit forms of the same subtype 2017-03-02 04:24:28 -08:00
PhabricatorEditEngineConfigurationSearchEngine.php Update EditEngine for two column 2016-03-28 09:18:55 -07:00
PhabricatorEditEngineConfigurationTransactionQuery.php Allow ApplicationEditor forms to be reconfigured 2015-11-10 10:24:40 -08:00
PhabricatorEditEngineQuery.php Allow form configurations to retitle and reorder forms and add preambles 2015-11-22 15:12:57 -08:00
PhabricatorEditEngineSearchEngine.php Reduce application search engine results list for Dashboards 2017-02-22 12:42:43 -08:00