mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-25 00:02:41 +01:00
18938b5310
Summary: Ref T2222. This is the big one. This migrates each `DifferentialComment` to one or more ApplicationTransactions (action, cc, reviewers, update, comment, inlines), and makes `DifferentialComment` a double-reader for ApplicationTransactions. The migration is pretty straightforward: - If a comment took an action not otherwise covered, it gets an "action" transaction. This is something like "epriestley abandoned this revision.". - If a comment updated the diff, it gets an "updated diff" transaction. Very old transactions of this type may not have a diff ID (probably only at Facebook). - If a comment added or removed reviewers, it gets a "changed reviewers" transaction. - If a comment added CCs, it gets a "subscribers" transaction. - If a comment added comment text, it gets a "comment" transaction. - For each inline attached to a comment, we generate an "inline" transaction. Most comments generate a small number of transactions, but a few generate a significant number. At HEAD, the code is basically already doing this, so comments in the last day or two already obey these rules, roughly, and will all generate only one transaction (except inlines). Because we've already preallocated PHIDs in the comment text table, we only need to write to the transaction table. NOTE: This significantly degrades Differential, making inline comments pretty much useless (they each get their own transaction, and don't show line numbers or files). The data is all fine, but the UI is garbage now. This needs to be fixed before we can deploy this to users, but it's easily separable since it's all just display code. Specifically, they look like this: {F112270} Test Plan: I've migrated locally and put things through their paces, but it's hard to catch sketchy stuff locally because most of my test data is nonsense and bad migrations wouldn't necessarily look out of place. IMPORTANT: I'm planning to push this to a branch and then shift production over to the branch, and run it for a day or two before bringing it to master. I generally feel good about this change: it's not that big since we were able to separate a lot of pieces out of it, and it's pretty straightforward. That said, it's still one of the most scary/dangerous changes we've ever made. Reviewers: btrahan CC: chad, aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8210 |
||
|---|---|---|
| .. | ||
| ConduitAPI_differential_close_Method.php | ||
| ConduitAPI_differential_createcomment_Method.php | ||
| ConduitAPI_differential_creatediff_Method.php | ||
| ConduitAPI_differential_createinline_Method.php | ||
| ConduitAPI_differential_createrawdiff_Method.php | ||
| ConduitAPI_differential_createrevision_Method.php | ||
| ConduitAPI_differential_find_Method.php | ||
| ConduitAPI_differential_finishpostponedlinters_Method.php | ||
| ConduitAPI_differential_getalldiffs_Method.php | ||
| ConduitAPI_differential_getcommitmessage_Method.php | ||
| ConduitAPI_differential_getcommitpaths_Method.php | ||
| ConduitAPI_differential_getdiff_Method.php | ||
| ConduitAPI_differential_getrawdiff_Method.php | ||
| ConduitAPI_differential_getrevision_Method.php | ||
| ConduitAPI_differential_getrevisioncomments_Method.php | ||
| ConduitAPI_differential_markcommitted_Method.php | ||
| ConduitAPI_differential_Method.php | ||
| ConduitAPI_differential_parsecommitmessage_Method.php | ||
| ConduitAPI_differential_query_Method.php | ||
| ConduitAPI_differential_querydiffs_Method.php | ||
| ConduitAPI_differential_setdiffproperty_Method.php | ||
| ConduitAPI_differential_updaterevision_Method.php | ||
| ConduitAPI_differential_updateunitresults_Method.php | ||