1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 02:32:42 +01:00
phorge-phorge/src/applications/differential/herald
epriestley 51b810b0eb Fix "Author's projects" Herald rules for revisions and diffs
Summary:
See PHI71. These didn't get properly updated when we wrote Subprojects and Milestones, and should use materialized members, not raw members. Swap the query so projects you are an indirect member of (e.g., milestones you are a member of the parent for, and parent projects you are a member of a subproject of) are included in the result list.

Also fix a bad typeahead datasource.

Test Plan:
  - Ran a dry run with the test console, saw project PHIDs for milestones and parent projects in the raw field value.
  - Tried to set "Author's projects" to a user, no longer could.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18619
2017-09-15 17:59:49 -07:00
..
DifferentialBlockHeraldAction.php Fix some copy/paste slop with BLOCK actions in Herald transcripts 2015-08-04 07:32:19 -07:00
DifferentialChangeHeraldFieldGroup.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DifferentialDiffAffectedFilesHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DifferentialDiffAuthorHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DifferentialDiffAuthorProjectsHeraldField.php Fix "Author's projects" Herald rules for revisions and diffs 2017-09-15 17:59:49 -07:00
DifferentialDiffContentAddedHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DifferentialDiffContentHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DifferentialDiffContentRemovedHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DifferentialDiffHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DifferentialDiffHeraldFieldGroup.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DifferentialDiffRepositoryHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DifferentialDiffRepositoryProjectsHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DifferentialReviewersAddBlockingReviewersHeraldAction.php Allow Herald to add package reviewers 2016-05-13 17:23:07 -07:00
DifferentialReviewersAddBlockingSelfHeraldAction.php Share target filtering code in HeraldAction 2015-08-03 14:34:37 -07:00
DifferentialReviewersAddReviewersHeraldAction.php Allow Herald to add package reviewers 2016-05-13 17:23:07 -07:00
DifferentialReviewersAddSelfHeraldAction.php Share target filtering code in HeraldAction 2015-08-03 14:34:37 -07:00
DifferentialReviewersHeraldAction.php Fix a bad getStatus() call which is fataling during Herald rule evaluation 2017-03-22 10:03:38 -07:00
DifferentialRevisionAffectedFilesHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DifferentialRevisionAuthorHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DifferentialRevisionAuthorProjectsHeraldField.php Fix "Author's projects" Herald rules for revisions and diffs 2017-09-15 17:59:49 -07:00
DifferentialRevisionContentAddedHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DifferentialRevisionContentHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DifferentialRevisionContentRemovedHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DifferentialRevisionHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DifferentialRevisionHeraldFieldGroup.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DifferentialRevisionPackageHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DifferentialRevisionPackageOwnerHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DifferentialRevisionRepositoryHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DifferentialRevisionRepositoryProjectsHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DifferentialRevisionReviewersHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DifferentialRevisionSummaryHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DifferentialRevisionTitleHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
HeraldDifferentialAdapter.php Modernize all Herald DifferentialDiff fields 2015-07-08 12:25:38 -07:00
HeraldDifferentialDiffAdapter.php Modularize the Diffusion/Differential "Block" Herald actions 2015-08-03 14:33:28 -07:00
HeraldDifferentialRevisionAdapter.php Rename "getReviewerStatus()" to "getReviewers()" 2017-03-20 17:11:40 -07:00