1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-17 02:50:54 +01:00
phorge-phorge/src/applications
epriestley 94d0adb140 Add "Undo" for editing Differential inline comments
Summary:
When a user hits 'cancel' on a 'new', 'edit', or 'reply' operation, add a little
"Changes discarded. __Undo__" insert so they can get their change back. No undo
for delete since there's an explicit prompt. Once this lands we can make
'escape' work again to close dialogs.

This change started feeling really good when I was merging all the duplicate
code and making things more consistent, but by the time I started writing client
rendering it felt gross. I'm not really thrilled with it but I guess it's a step
forward? The feature seems pretty OK in practice. Let me know how much barfing
this causes and I can try to remedy the most acute concerns.

This also fixes a bug where replies always (?) appear on the 'new' side of the
diff (I think?).

Test Plan:
Applied 'new', 'edit', 'delete' and 'reply' operations, pressed 'cancel' and
'okay' in each case, with and without changing text where relevant. All
behaviors seem to conform with expectations, except that canceling out of 'edit'
without changing the text gives you an option to undo when it shouldn't really.
There's no super easy way to get at the original text right now.

Reviewed By: aran
Reviewers: aran, jungejason, tuomaspelkonen
CC: simpkins, aran, epriestley
Differential Revision: 406
2011-06-08 10:44:01 -07:00
..
auth Revise administrative workflow for user creation 2011-05-31 13:06:32 -07:00
base Enable multiple web sessions 2011-05-12 18:45:19 -07:00
conduit Minor IRCBot fixes/upgrades 2011-05-30 12:24:39 -07:00
daemon Improve web tools for viewing daemons 2011-05-03 06:38:12 -07:00
differential Add "Undo" for editing Differential inline comments 2011-06-08 10:44:01 -07:00
diffusion diffusion: fix git log author name parsing 2011-06-06 18:17:40 -07:00
directory Use Javelin workflow on directory item deletion 2011-05-28 11:57:31 -07:00
draft/storage Revision comment drafts. 2011-02-05 16:57:21 -08:00
files Link macro thumbs and show an exact page count 2011-06-02 17:20:30 -07:00
help/controller Provide basic structure for keyboard shortcuts 2011-06-07 11:23:19 -07:00
herald Adding paging to transcript pages 2011-05-08 15:59:39 -07:00
maniphest Simplify Maniphest button filter toggle things 2011-06-01 15:40:50 -07:00
metamta Fix UTF-8 in email 2011-06-06 17:53:20 -07:00
owners Removing reordering code that wasn't needed 2011-04-20 17:07:46 -07:00
people Fix regenerate arcanist cert, setup stuff and avoid accept non valid image files as profile picture. 2011-06-02 23:27:10 -03:00
phid Support email multiplexing for private Reply-To addresses 2011-05-11 20:21:57 -07:00
preferences/controller Add missing includes from XHPAST parse bug. 2011-04-06 23:14:58 -07:00
project Add missing includes from XHPAST parse bug. 2011-04-06 23:14:58 -07:00
repository Verify that SVN repository URI ends in a "/" 2011-05-18 10:37:53 -07:00
search Allow revisions to be edited from Maniphest 2011-05-16 15:31:46 -07:00
status/base Add /status/ 2011-04-08 11:13:51 -07:00
typeahead/controller Provide an activity log for login and administrative actions 2011-05-20 19:08:26 -07:00
uiexample Add missing includes from XHPAST parse bug. 2011-04-06 23:14:58 -07:00
xhpastview Add missing includes from XHPAST parse bug. 2011-04-06 23:14:58 -07:00
xhprof Lint fluff. 2011-02-06 12:58:01 -08:00