1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/diffusion
epriestley 95e179d9a4 Fix a fatal in the document engine blame view with files that blame to the initial commit
Summary:
Ref T13126. When you view a file using the new document engine view and some lines were introduced in the initial commit to the repository, Git renders "^abc123" in the blame output.

We currently don't do anything about this, and later fail to look it up and fatal.

It's also unlikely-but-conceivably-possible to end up here if a commit has not imported yet or has been nuked with `bin/remove destroy`.

Let the whole thing run without fataling even if a `$commit` is missing. Future refinements could improve this behavior.

Test Plan: Viewed a file with lines introduced in the initial commit, got empty blame instead of a fatal.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13126

Differential Revision: https://secure.phabricator.com/D19391
2018-04-20 14:12:50 -07:00
..
application Mostly make blame work with DocumentEngine 2018-04-09 04:48:21 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Fix another Git 2.16.0 CLI compatibility issue 2018-02-07 17:54:39 -08:00
config Move the Git LFS gate to dedicated (non-prototype) config 2017-12-18 09:12:22 -08:00
controller Fix a fatal in the document engine blame view with files that blame to the initial commit 2018-04-20 14:12:50 -07:00
data When users browse to a submodule path in Diffusion explicitly, don't fatal 2017-12-18 09:18:22 -08:00
document Restore coverage reporting to Diffusion browse UI 2018-04-17 14:51:47 -07:00
doorkeeper Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
edge Allow revisions to revert commits and one another, and commits to revert revisions 2018-02-02 08:25:58 -08:00
editor Fix typo in new setting description 2018-01-06 07:25:27 -08:00
engine Fix a commit hook issue where pushing dangerous changes would fatal before hitting the dragon bureaucrats 2018-04-05 06:19:49 -07:00
engineextension Modularize the "jump nav" behaviors in global search 2018-02-14 18:08:07 -08:00
exception Filter and reject "--config" and "--debugger" flags to Mercurial in any position 2017-11-10 08:42:07 -08:00
garbagecollector Support ID-based repository URIs, and canonicalize repository URIs 2016-02-18 09:56:28 -08:00
gitlfs Fix a missing getSSHUser() callsite 2018-01-31 15:34:12 -08:00
harbormaster Provide a modular buildable transaction in Diffusion 2018-04-03 11:01:37 -07:00
herald When evaluating the "Branches" Herald field from the test console, use the current viewer 2018-02-27 14:37:36 -08:00
management Prevent enormous changes from being pushed to repositoires by default 2018-01-04 10:02:29 -08:00
panel Bring new password validation into AuthPasswordEngine 2018-01-23 10:58:37 -08:00
protocol Record lock timing information on PushEvents 2018-03-22 13:46:01 -07:00
query Change the "can see remote address?" policy to "is administrator?" everywhere 2018-01-30 15:45:23 -08:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup When commits have a "rewritten" hint, try to show that in handles in other applications 2016-08-24 09:35:19 -07:00
request Add profile images to Repositories 2017-06-12 07:51:39 -07:00
response Implement a Git LFS server which supports no operations 2016-03-17 08:08:43 -07:00
ssh Allow repository cluster bindings to be marked as not "writable", making them read-only 2018-04-12 16:10:36 -07:00
symbol Provide character position information to symbol queries 2018-01-26 13:01:57 -08:00
typeahead Fix an issue where repositories with hyphens could sort improperly in typeaheads 2017-07-03 09:28:02 -07:00
view Make Harbormaster buildable status more of a nice flexible map and less of a bunch of switch statements 2018-02-12 12:18:06 -08:00
xaction Provide a modular buildable transaction in Diffusion 2018-04-03 11:01:37 -07:00
DiffusionLintSaveRunner.php Return Diffusion diffs through Files, not directly over Conduit 2016-08-27 09:11:03 -07:00