1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-16 03:42:41 +01:00
phorge-phorge/src/applications/repository
epriestley 8599145b5e Implement more consistent publishing rules for repositories
Summary:
Ref T7298. We are currently inconsistent about when we publish feed, email, notifications, audits and Herald rules.

Specifically, there are two settings which impact these things:

  - The "importing" flag, which is set when we're importing old commits.
  - The "herald-disabled" flag, which was expanded in scope some time ago and now actually means "disable publishing".

Various parts of the pipeline were checking only one of these flags. Instead, all of them should check both.

(For example, we should never email users about importing repositories, nor trigger audits on them.)

Test Plan: See next revision.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7298

Differential Revision: https://secure.phabricator.com/D11826
2015-02-19 10:38:05 -08:00
..
application Remove getIconName from all applications 2015-01-30 12:11:21 -08:00
conduit Rename AphrontQueryException subclasses 2014-08-06 07:51:21 +10:00
config Add getGroup to ConfigOptions 2015-02-09 13:10:56 -08:00
constants Build an early multi-step repository create form 2013-07-14 07:37:17 -07:00
controller Modernize "arcanist project" datasource 2014-07-10 16:21:10 -07:00
customfield Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
daemon Only increment status message cursor if we're going to consume the message 2015-02-18 12:53:37 -08:00
data Fix pht method calls 2015-02-10 18:57:45 +11:00
editor Modernize remaining edge types 2015-01-03 10:58:20 +11:00
engine Promote instance identity to the upstream and pass it to commit hooks 2015-01-27 14:51:48 -08:00
graphcache Fix various spelling mistakes 2014-07-13 00:45:33 +10:00
mail Allow users to receive email about pushes via Herald 2014-03-26 13:51:15 -07:00
management Improve visibility of repository credential errors 2015-02-19 10:32:25 -08:00
phid Fix some linter violations 2015-01-03 09:11:41 +11:00
query Policy - filter app engines where the user can't see the application from panel editing 2015-02-04 15:47:48 -08:00
response Accept and route VCS HTTP requests 2013-10-29 15:32:40 -07:00
search Diffusion - make projects work properly with commits 2014-11-19 14:43:59 -08:00
storage Implement more consistent publishing rules for repositories 2015-02-19 10:38:05 -08:00
worker Implement more consistent publishing rules for repositories 2015-02-19 10:38:05 -08:00