1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-16 03:42:41 +01:00
phorge-phorge/src/applications/repository/storage
epriestley 8599145b5e Implement more consistent publishing rules for repositories
Summary:
Ref T7298. We are currently inconsistent about when we publish feed, email, notifications, audits and Herald rules.

Specifically, there are two settings which impact these things:

  - The "importing" flag, which is set when we're importing old commits.
  - The "herald-disabled" flag, which was expanded in scope some time ago and now actually means "disable publishing".

Various parts of the pipeline were checking only one of these flags. Instead, all of them should check both.

(For example, we should never email users about importing repositories, nor trigger audits on them.)

Test Plan: See next revision.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7298

Differential Revision: https://secure.phabricator.com/D11826
2015-02-19 10:38:05 -08:00
..
__tests__ Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
PhabricatorRepository.php Implement more consistent publishing rules for repositories 2015-02-19 10:38:05 -08:00
PhabricatorRepositoryArcanistProject.php Policy - remove loadRepository() method from ArcanistProjects 2015-02-02 13:58:33 -08:00
PhabricatorRepositoryAuditRequest.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
PhabricatorRepositoryBranch.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
PhabricatorRepositoryCommit.php Set "importStatus" as nonmutable on save() 2015-02-19 10:36:36 -08:00
PhabricatorRepositoryCommitData.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
PhabricatorRepositoryDAO.php Delete license headers from files 2012-11-05 11:16:51 -08:00
PhabricatorRepositoryMirror.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
PhabricatorRepositoryPushEvent.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
PhabricatorRepositoryPushLog.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
PhabricatorRepositoryRefCursor.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
PhabricatorRepositorySchemaSpec.php Automatically build all Lisk schemata 2014-10-02 09:51:20 -07:00
PhabricatorRepositoryStatusMessage.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
PhabricatorRepositorySymbol.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
PhabricatorRepositoryTransaction.php When repository services are available, use them when creating a new repository 2014-12-18 14:31:22 -08:00
PhabricatorRepositoryVCSPassword.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00