mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-01 03:02:43 +01:00
ab4743b216
Summary: Currently, PhortuneAccounts have a very open default policy to allow merchants to see and interact with them. This has the undesirable side effect of leaking their names in too many places, because all users are allowed to load the handles for the accounts. Although this information is not super sensitive, we shouldn't expose it. I went through about 5 really messy diffs trying to fix this. It's very complicated because there are a lot of objects and many of them are related to PhortuneAccounts, but PhortuneAccounts are not bound to a specific merchant. This lead to a lot of threading viewers and merchants all over the place through the call stack and some really sketchy diffs with OmnipotentUsers that weren't going anywhere good. This is the cleanest approach I came up with, by far: - Introduce the concept of an "Authority", which gives a user more powers as a viewer. For now, since we only have one use case, this is pretty open-ended. - When a viewer is acting as a merchant, grant them authority through the merchant. - Have Accounts check if the viewer is acting with merchant authority. This lets us easily implement the rule "merchants can see this stuff" without being too broad. Then update the Subscription view to respect Merchant Authority. I partially updated the Cart views to respect it. I'll finish this up in a separate diff, but this seemed like a good checkpoint that introduced the concept without too much extra baggage. This feels pretty good/clean to me, overall, even ignoring the series of horrible messes I made on my way here. Test Plan: - Verified I can see everything I need to as a merchant (modulo un-updated Cart UIs). - Verified I can see nothing when acting as a normal user. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D11945 |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| PhabricatorExternalAccount.php | ||
| PhabricatorRegistrationProfile.php | ||
| PhabricatorUser.php | ||
| PhabricatorUserConfiguredCustomFieldStorage.php | ||
| PhabricatorUserCustomFieldNumericIndex.php | ||
| PhabricatorUserCustomFieldStringIndex.php | ||
| PhabricatorUserDAO.php | ||
| PhabricatorUserEmail.php | ||
| PhabricatorUserLog.php | ||
| PhabricatorUserProfile.php | ||
| PhabricatorUserSchemaSpec.php | ||
| PhabricatorUserTransaction.php | ||