mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-14 02:42:40 +01:00
9838251515
Summary: Fixes T2691. Now, all PhabricatorActionListViews in the codebase setObjectHref to $request->getRequestURI. This value is passed over to PhabricatorActionItems right before they are rendered. If a PhabricatorActionItem is a workflow and there is no user OR the user is logged out, we used this objectURI to construct a log in URI. Potentially added some undesirable behavior to aggressively setUser (and later setObjectURI) from within the List on Actions... This should be okay-ish unless there was a vision of actions having different user objects associated with them. I think this is a safe assumption. Test Plan: played around with a mock all logged out (Ref T2652) and it worked! Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2691 Differential Revision: https://secure.phabricator.com/D6416 |
||
---|---|---|
.. | ||
__tests__ | ||
AphrontContextBarView.php | ||
AphrontListFilterView.php | ||
AphrontMiniPanelView.php | ||
AphrontMoreView.php | ||
AphrontMultiColumnView.php | ||
AphrontPanelView.php | ||
AphrontSideNavFilterView.php | ||
AphrontTwoColumnView.php | ||
PhabricatorActionHeaderView.php | ||
PhabricatorActionListView.php | ||
PhabricatorActionView.php | ||
PhabricatorAnchorView.php | ||
PhabricatorCrumbsView.php | ||
PhabricatorCrumbView.php | ||
PhabricatorFileLinkListView.php | ||
PhabricatorFileLinkView.php | ||
PhabricatorHeaderView.php | ||
PhabricatorObjectItemListView.php | ||
PhabricatorObjectItemView.php | ||
PhabricatorPinboardItemView.php | ||
PhabricatorPinboardView.php | ||
PhabricatorPropertyListView.php | ||
PhabricatorSourceCodeView.php | ||
PhabricatorTagView.php | ||
PhabricatorTimelineEventView.php | ||
PhabricatorTimelineView.php | ||
PhabricatorTransactionView.php | ||
PhabricatorWorkboardView.php | ||
PhabricatorWorkpanelView.php |