1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-14 02:42:40 +01:00
phorge-phorge/src/view/layout
Bob Trahan 9838251515 Make PhabricatorActionListView logged-out user savvy
Summary:
Fixes T2691. Now, all PhabricatorActionListViews in the codebase setObjectHref to $request->getRequestURI. This value is passed over to PhabricatorActionItems right before they are rendered. If a PhabricatorActionItem is a workflow and there is no user OR the user is logged out, we used this objectURI to construct a log in URI.

Potentially added some undesirable behavior to aggressively setUser (and later setObjectURI) from within the List on Actions... This should be okay-ish unless there was a vision of actions having different user objects associated with them. I think this is a safe assumption.

Test Plan: played around with a mock all logged out (Ref T2652) and it worked!

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2691

Differential Revision: https://secure.phabricator.com/D6416
2013-07-12 11:39:47 -07:00
..
__tests__ PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
AphrontContextBarView.php Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
AphrontListFilterView.php Fix shadown on aphront filter viewy 2013-07-03 09:25:05 -07:00
AphrontMiniPanelView.php Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
AphrontMoreView.php render_tag -> tag: fix more callsites (more view, misc) 2013-01-31 09:08:02 -08:00
AphrontMultiColumnView.php Add Shadow Panels to PhabricatorMultiColumnView 2013-05-21 15:28:43 -07:00
AphrontPanelView.php Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
AphrontSideNavFilterView.php PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
AphrontTwoColumnView.php Phriction Redesign 2013-04-11 15:05:50 -07:00
PhabricatorActionHeaderView.php Conpherence - make widget selector be a fun JS-based menu 2013-05-24 10:50:18 -07:00
PhabricatorActionListView.php Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
PhabricatorActionView.php Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
PhabricatorAnchorView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
PhabricatorCrumbsView.php PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
PhabricatorCrumbView.php Conpherence - make widget selector be a fun JS-based menu 2013-05-24 10:50:18 -07:00
PhabricatorFileLinkListView.php Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
PhabricatorFileLinkView.php Conpherence - make the files widget purdy-ish 2013-03-15 23:41:36 -07:00
PhabricatorHeaderView.php Use ActionListView for all profile actions 2013-07-10 05:11:08 -07:00
PhabricatorObjectItemListView.php Make PhabricatorObjectItemListView extend AphrontTagView 2013-06-02 09:39:44 -07:00
PhabricatorObjectItemView.php Add a "disabled" style 2013-07-12 11:31:20 -07:00
PhabricatorPinboardItemView.php Add action icons to object list views 2013-05-10 12:57:01 -07:00
PhabricatorPinboardView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
PhabricatorPropertyListView.php Move roles and status into properties on profile view 2013-07-10 12:34:09 -07:00
PhabricatorSourceCodeView.php Line count can be set for paste 2013-03-14 10:51:34 -07:00
PhabricatorTagView.php Add remarkup support for Asana URIs 2013-06-24 15:55:08 -07:00
PhabricatorTimelineEventView.php Add action icons to object list views 2013-05-10 12:57:01 -07:00
PhabricatorTimelineView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
PhabricatorTransactionView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
PhabricatorWorkboardView.php PHUIIconView 2013-04-19 17:44:20 -07:00
PhabricatorWorkpanelView.php PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00