mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-29 08:50:58 +01:00
cbd3c0b7ac
Summary:
We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well.
Instead, provide first-class actions:
{F42978}
They produce targets which my meaty ham-fists can plausibly hit on mobile, too:
{F42979}
(We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?)
Test Plan: Added UIExamples. Checked desktop/mobile.
Reviewers: chad, btrahan, edward
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D5890
114 lines
2.4 KiB
PHP
114 lines
2.4 KiB
PHP
<?php
|
|
|
|
final class PhabricatorPinboardItemView extends AphrontView {
|
|
|
|
private $imageURI;
|
|
private $uri;
|
|
private $header;
|
|
private $iconBlock = array();
|
|
|
|
private $imageWidth;
|
|
private $imageHeight;
|
|
|
|
public function setHeader($header) {
|
|
$this->header = $header;
|
|
return $this;
|
|
}
|
|
|
|
public function setURI($uri) {
|
|
$this->uri = $uri;
|
|
return $this;
|
|
}
|
|
|
|
public function setImageURI($image_uri) {
|
|
$this->imageURI = $image_uri;
|
|
return $this;
|
|
}
|
|
|
|
public function setImageSize($x, $y) {
|
|
$this->imageWidth = $x;
|
|
$this->imageHeight = $y;
|
|
return $this;
|
|
}
|
|
|
|
public function addIconCount($icon, $count) {
|
|
$this->iconBlock[] = array($icon, $count);
|
|
return $this;
|
|
}
|
|
|
|
public function render() {
|
|
$header = null;
|
|
if ($this->header) {
|
|
$header = phutil_tag(
|
|
'div',
|
|
array(
|
|
'class' => 'phabricator-pinboard-item-header',
|
|
),
|
|
phutil_tag('a', array('href' => $this->uri), $this->header));
|
|
}
|
|
|
|
$image = phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $this->uri,
|
|
'class' => 'phabricator-pinboard-item-image-link',
|
|
),
|
|
phutil_tag(
|
|
'img',
|
|
array(
|
|
'src' => $this->imageURI,
|
|
'width' => $this->imageWidth,
|
|
'height' => $this->imageHeight,
|
|
)));
|
|
|
|
$icons = array();
|
|
if ($this->iconBlock) {
|
|
$icon_list = array();
|
|
foreach ($this->iconBlock as $block) {
|
|
$icon = phutil_tag(
|
|
'span',
|
|
array(
|
|
'class' =>
|
|
'phabricator-pinboard-icon sprite-icons icons-'.$block[0].'-grey',
|
|
),
|
|
'');
|
|
$count = phutil_tag('span', array(), $block[1]);
|
|
$icon_list[] = phutil_tag(
|
|
'span',
|
|
array(
|
|
'class' => 'phabricator-pinboard-item-count',
|
|
),
|
|
array($icon, $count));
|
|
}
|
|
$icons = phutil_tag(
|
|
'div',
|
|
array(
|
|
'class' => 'phabricator-pinboard-icons',
|
|
),
|
|
$icon_list);
|
|
}
|
|
|
|
$content = $this->renderChildren();
|
|
if ($content) {
|
|
$content = phutil_tag(
|
|
'div',
|
|
array(
|
|
'class' => 'phabricator-pinboard-item-content',
|
|
),
|
|
$content);
|
|
}
|
|
|
|
return phutil_tag(
|
|
'div',
|
|
array(
|
|
'class' => 'phabricator-pinboard-item-view',
|
|
),
|
|
array(
|
|
$header,
|
|
$image,
|
|
$icons,
|
|
$content,
|
|
));
|
|
}
|
|
|
|
}
|