revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-25 21:19:21 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/harbormaster/controller
History
epriestley d36d0efc35 Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing, restartable, runnable 
Summary:
Depends on D20219. Ref T13258. Ref T11415. Installs sometimes have long-running builds or unimportant builds which they may not want to hold up drafts, affect buildable status, or warn during `arc land`.

Some builds have side effects (like deployment or merging) and are not idempotent. They can cause problems if restarted.

In other cases, builds are isolated and idempotent and generally safe, and it's okay for marketing interns to restart them.

To address these cases, add "Behaviors" to Build Plans:

  - Hold Drafts: Controls how the build affects revision promotion from "Draft".
  - Warn on Land: Controls the "arc land" warning.
  - Affects Buildable: Controls whether we care about this build when figuring out if a buildable passed or failed overall.
  - Restartable: Controls whether this build may restart or not.
  - Runnable: Allows you to weaken the requirements to run the build if you're confident it's safe to run it on arbitrary old versions of things.

NOTE: This only implements UI, none of these options actually do anything yet.

Test Plan:
Mostly poked around the UI. I'll actually implement these behaviors next, and vet them more thoroughly.

{F6244828}

{F6244830}

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13258, T11415

Differential Revision: https://secure.phabricator.com/D20220
2019-03-06 05:40:06 -08:00
..
HarbormasterBuildableActionController.php Require "Can Edit" on a build plan to abort or pause associated builds 2016-02-26 11:38:43 -08:00
HarbormasterBuildableListController.php Provide a basic search engine for builds 2016-07-31 13:35:31 +00:00
HarbormasterBuildableViewController.php Give HarbormasterBuildUnitMessage a real Query class 2019-02-15 19:16:47 -08:00
HarbormasterBuildActionController.php Add an "Abort Older Builds" build step to Harbormaster 2018-04-17 14:59:47 -07:00
HarbormasterBuildkiteHookController.php Integrate Harbormaster with Buildkite 2017-01-31 09:19:43 -08:00
HarbormasterBuildListController.php Provide a basic search engine for builds 2016-07-31 13:35:31 +00:00
HarbormasterBuildLogDownloadController.php Support logged-out access to more Harbormaster controllers 2018-06-04 10:11:25 -07:00
HarbormasterBuildLogRenderController.php Support logged-out access to more Harbormaster controllers 2018-06-04 10:11:25 -07:00
HarbormasterBuildLogViewController.php Support logged-out access to more Harbormaster controllers 2018-06-04 10:11:25 -07:00
HarbormasterBuildViewController.php Support logged-out access to more Harbormaster controllers 2018-06-04 10:11:25 -07:00
HarbormasterCircleCIHookController.php Add a CircleCI webhook 2016-03-22 12:12:36 -07:00
HarbormasterController.php Use EditEngine for Harbormaster Build Plans, fix some crumbs/mobile stuff 2016-02-27 07:13:29 -08:00
HarbormasterLintMessagesController.php Support logged-out access to more Harbormaster controllers 2018-06-04 10:11:25 -07:00
HarbormasterPlanBehaviorController.php Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing, restartable, runnable 2019-03-06 05:40:06 -08:00
HarbormasterPlanController.php Use EditEngine for Harbormaster Build Plans, fix some crumbs/mobile stuff 2016-02-27 07:13:29 -08:00
HarbormasterPlanDisableController.php Move Harbormaster Build Plans to modular transactions 2019-02-28 07:32:13 -08:00
HarbormasterPlanEditController.php Use EditEngine for Harbormaster Build Plans, fix some crumbs/mobile stuff 2016-02-27 07:13:29 -08:00
HarbormasterPlanListController.php Use EditEngine for Harbormaster Build Plans, fix some crumbs/mobile stuff 2016-02-27 07:13:29 -08:00
HarbormasterPlanRunController.php Start buildables in "PREPARING", move them to "BUILDING" after builds queue 2018-02-12 12:18:29 -08:00
HarbormasterPlanViewController.php Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing, restartable, runnable 2019-03-06 05:40:06 -08:00
HarbormasterStepAddController.php Update Harbormaster for two column 2016-03-25 21:41:47 +00:00
HarbormasterStepDeleteController.php Use EditEngine for Harbormaster Build Plans, fix some crumbs/mobile stuff 2016-02-27 07:13:29 -08:00
HarbormasterStepEditController.php Update Harbormaster for two column 2016-03-25 21:41:47 +00:00
HarbormasterStepViewController.php Support logged-out access to more Harbormaster controllers 2018-06-04 10:11:25 -07:00
HarbormasterUnitMessageListController.php Give HarbormasterBuildUnitMessage a real Query class 2019-02-15 19:16:47 -08:00
HarbormasterUnitMessageViewController.php Give HarbormasterBuildUnitMessage a real Query class 2019-02-15 19:16:47 -08:00