mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-26 05:29:06 +01:00
66f20595e4
Summary: Depends on D19064. Ref T13054. See that task for additional discussion. When buildables are created by `arc` and have lint/unit messages, they can currently pass or fail before Herald triggers actual builds. This puts them in a pre-build state where they can't complete until Herald says it's okay. On its own, this change intentionally strands `arc diff --only` diffs in the "PREPARING" stage forever. Test Plan: - Ran a build with `bin/harbormaster`, saw it build normally. - Ran a build with web UI, saw it build normally. - Ran a build with `arc diff`, saw it build normally. - Ran a build with `arc diff --only`, saw it hang in "PREPARING" forever. Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13054 Differential Revision: https://secure.phabricator.com/D19065
107 lines
3.2 KiB
PHP
107 lines
3.2 KiB
PHP
<?php
|
|
|
|
final class HarbormasterPlanRunController extends HarbormasterPlanController {
|
|
|
|
public function handleRequest(AphrontRequest $request) {
|
|
$viewer = $this->getViewer();
|
|
$plan_id = $request->getURIData('id');
|
|
|
|
$plan = id(new HarbormasterBuildPlanQuery())
|
|
->setViewer($viewer)
|
|
->withIDs(array($plan_id))
|
|
->requireCapabilities(
|
|
array(
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
))
|
|
->executeOne();
|
|
if (!$plan) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$cancel_uri = $this->getApplicationURI("plan/{$plan_id}/");
|
|
|
|
if (!$plan->canRunManually()) {
|
|
return $this->newDialog()
|
|
->setTitle(pht('Can Not Run Plan'))
|
|
->appendParagraph(pht('This plan can not be run manually.'))
|
|
->addCancelButton($cancel_uri);
|
|
}
|
|
|
|
$e_name = true;
|
|
$v_name = null;
|
|
|
|
$errors = array();
|
|
if ($request->isFormPost()) {
|
|
$buildable = HarbormasterBuildable::initializeNewBuildable($viewer)
|
|
->setIsManualBuildable(true);
|
|
|
|
$v_name = $request->getStr('buildablePHID');
|
|
|
|
if ($v_name) {
|
|
$object = id(new PhabricatorObjectQuery())
|
|
->setViewer($viewer)
|
|
->withNames(array($v_name))
|
|
->executeOne();
|
|
|
|
if ($object instanceof HarbormasterBuildableInterface) {
|
|
$buildable
|
|
->setBuildablePHID($object->getHarbormasterBuildablePHID())
|
|
->setContainerPHID($object->getHarbormasterContainerPHID());
|
|
} else {
|
|
$e_name = pht('Invalid');
|
|
$errors[] = pht('Enter the name of a revision or commit.');
|
|
}
|
|
} else {
|
|
$e_name = pht('Required');
|
|
$errors[] = pht('You must choose a revision or commit to build.');
|
|
}
|
|
|
|
if (!$errors) {
|
|
$buildable->save();
|
|
|
|
$buildable->sendMessage(
|
|
$viewer,
|
|
HarbormasterMessageType::BUILDABLE_BUILD,
|
|
false);
|
|
|
|
$buildable->applyPlan($plan, array(), $viewer->getPHID());
|
|
|
|
$buildable_uri = '/B'.$buildable->getID();
|
|
return id(new AphrontRedirectResponse())->setURI($buildable_uri);
|
|
}
|
|
}
|
|
|
|
if ($errors) {
|
|
$errors = id(new PHUIInfoView())->setErrors($errors);
|
|
}
|
|
|
|
$title = pht('Run Build Plan Manually');
|
|
$save_button = pht('Run Plan Manually');
|
|
|
|
$form = id(new PHUIFormLayoutView())
|
|
->setUser($viewer)
|
|
->appendRemarkupInstructions(
|
|
pht(
|
|
"Enter the name of a commit or revision to run this plan on (for ".
|
|
"example, `rX123456` or `D123`).\n\n".
|
|
"For more detailed output, you can also run manual builds from ".
|
|
"the command line:\n\n".
|
|
" phabricator/ $ ./bin/harbormaster build <object> --plan %s",
|
|
$plan->getID()))
|
|
->appendChild(
|
|
id(new AphrontFormTextControl())
|
|
->setLabel(pht('Buildable Name'))
|
|
->setName('buildablePHID')
|
|
->setError($e_name)
|
|
->setValue($v_name));
|
|
|
|
return $this->newDialog()
|
|
->setWidth(AphrontDialogView::WIDTH_FULL)
|
|
->setTitle($title)
|
|
->appendChild($form)
|
|
->addCancelButton($cancel_uri)
|
|
->addSubmitButton($save_button);
|
|
}
|
|
|
|
}
|