revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-22 10:18:48 +02:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
Bob Trahan 98c2ad38e5 Fix audit commenting where there are only inlines 
Summary: been some changes here and this code was broked. turns out we re-assign $action like two lines later and never used the initial value, so we can simply delete the offending line. Fixes T5745.

Test Plan: submitted inline comment pre-patch and fatal. re-submitted post patch and great success!

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5745

Differential Revision: https://secure.phabricator.com/D10078
2014-07-30 10:50:01 -07:00
..
aphlict/management Try nodejs before node when starting notification server 2014-06-07 13:56:23 -07:00
arcanist/conduit Rename Conduit classes 2014-07-25 10:54:15 +10:00
audit Fix audit commenting where there are only inlines 2014-07-30 10:50:01 -07:00
auth Rename PHIDType classes 2014-07-24 08:05:46 +10:00
base Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
cache Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
calendar Rename PHIDType classes 2014-07-24 08:05:46 +10:00
chatlog Fix some missing renames of Application classes 2014-07-24 18:03:59 -07:00
conduit Omit unnecessary function call 2014-07-25 23:17:52 +10:00
config Rename PHIDType classes 2014-07-24 08:05:46 +10:00
conpherence Rename Conduit classes 2014-07-25 10:54:15 +10:00
countdown Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
daemon Rename PhabricatorApplication subclasses 2014-07-23 10:03:09 +10:00
dashboard Rename PHIDType classes 2014-07-24 08:05:46 +10:00
differential Rename Conduit classes 2014-07-25 10:54:15 +10:00
diffusion Convert Audit comment rendering to standard infrastructure 2014-07-28 15:01:43 -07:00
diviner Use Source Sans for Phriction 2014-07-28 10:36:16 -07:00
doorkeeper Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
draft/storage Differential - add DifferentialDraft to track whether revisions have draft feedback or not 2014-02-18 16:25:16 -08:00
drydock Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
fact Rename PhabricatorApplication subclasses 2014-07-23 10:03:09 +10:00
feed Fix some missing renames of Application classes 2014-07-24 18:03:59 -07:00
files Fix some missing renames of Application classes 2014-07-24 18:03:59 -07:00
flag Rename Conduit classes 2014-07-25 10:54:15 +10:00
harbormaster Rename Conduit classes 2014-07-25 10:54:15 +10:00
help Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
herald Use authoritative PHIDs for Herald "Task Projects" condition 2014-07-26 09:48:01 -07:00
home Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
legalpad Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
lipsum Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
macro Fix some missing renames of Application classes 2014-07-24 18:03:59 -07:00
mailinglists Rename PHIDType classes 2014-07-24 08:05:46 +10:00
maniphest Rename Conduit classes 2014-07-25 10:54:15 +10:00
meta Rename PHIDType classes 2014-07-24 08:05:46 +10:00
metamta Rename PHIDType classes 2014-07-24 08:05:46 +10:00
notification Add some missing application names 2014-07-23 08:15:44 -07:00
nuance Fix some missing renames of Application classes 2014-07-24 18:03:59 -07:00
oauthserver Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
owners Fix some missing renames of Application classes 2014-07-24 18:03:59 -07:00
passphrase Rename PHIDType classes 2014-07-24 08:05:46 +10:00
paste Rename Conduit classes 2014-07-25 10:54:15 +10:00
people Rename Conduit classes 2014-07-25 10:54:15 +10:00
phame Render Phame templates in the expected order 2014-07-28 19:08:45 -07:00
phid Rename Conduit classes 2014-07-25 10:54:15 +10:00
phlux Rename PHIDType classes 2014-07-24 08:05:46 +10:00
pholio Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
phortune Fix Phortune application name 2014-07-25 08:13:39 +10:00
phpast Add some missing application names 2014-07-23 08:15:44 -07:00
phragment Fix some missing renames of Application classes 2014-07-24 18:03:59 -07:00
phrequent Fix some missing renames of Application classes 2014-07-24 18:03:59 -07:00
phriction Use Source Sans for Phriction 2014-07-28 10:36:16 -07:00
policy Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
ponder Rename PHIDType classes 2014-07-24 08:05:46 +10:00
project Rename Conduit classes 2014-07-25 10:54:15 +10:00
releeph Rename Conduit classes 2014-07-25 10:54:15 +10:00
remarkup/conduit Rename Conduit classes 2014-07-25 10:54:15 +10:00
repository Use ApplicationTransactions when indexing commit/audit comments 2014-07-28 15:02:18 -07:00
search Use ApplicationTransactions when indexing commit/audit comments 2014-07-28 15:02:18 -07:00
settings Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
slowvote Fix some missing renames of Application classes 2014-07-24 18:03:59 -07:00
subscriptions Rename PHIDType classes 2014-07-24 08:05:46 +10:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
tokens Rename Conduit classes 2014-07-25 10:54:15 +10:00
transactions Convert Audit comment rendering to standard infrastructure 2014-07-28 15:01:43 -07:00
typeahead Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
uiexample Rename PHIDType classes 2014-07-24 08:05:46 +10:00
xhprof Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00