1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-22 04:31:13 +01:00
phorge-phorge/src/applications/metamta
Andre Klapper 186768ccfd Fix PHP 8.1 "strlen(null)" exception when received email lacks From header
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php:527]
```

Closes T15767

Test Plan: See T15767

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15767

Differential Revision: https://we.phorge.it/D25564
2024-03-31 15:21:11 +02:00
..
action Simplify implementation of "SysetemAction->getSystemActionConstant()" 2019-07-19 15:45:37 -07:00
adapter Remove product literal strings in "pht()", part 6 2022-04-25 12:22:28 -07:00
application Support Postmark inbound mail via webhook 2018-02-08 06:25:26 -08:00
applicationpanel Remove product literal strings in "pht()", part 20 2022-04-25 16:46:25 -07:00
command Use PhutilClassMapQuery 2015-07-07 22:51:57 +10:00
constants Remove product literal strings in "pht()", part 6 2022-04-25 12:22:28 -07:00
contentsource Modularize content sources 2016-03-26 11:59:45 -07:00
controller Fix PHP 8.1 "strlen(null)" exception shown when sending SMS Test Message to Contact Number 2023-05-19 17:01:16 +02:00
edge MetaMTA - more progress towards a mail application 2015-06-23 11:37:14 -07:00
editor Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
engine PHP 8.2: fixes for strlen() not accepting NULL anymore, part 1 2023-03-31 22:05:52 +02:00
engineextension Manage object mailKeys automatically in Mail instead of storing them on objects 2018-04-25 06:46:58 -07:00
exception PHP 8.2: fix deprecated use of "parent" in callables 2023-03-29 20:37:25 +02:00
future Update SES API to use AWSv4 signatures 2020-09-15 13:03:49 -07:00
garbagecollector Support DestructionEngine in MetaMTAMail 2018-02-02 14:37:33 -08:00
herald Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
management Change some instances of "phabricator" to "phorge" 2023-11-18 22:14:15 +00:00
message Give "MetaMTAMail" a "message type" and support SMS 2019-01-23 14:05:46 -08:00
parser Remove product literal strings in "pht()", part 6 2022-04-25 12:22:28 -07:00
phid Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
query Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
receiver Remove product literal strings in "pht()", part 20 2022-04-25 16:46:25 -07:00
replyhandler Drop empty inbound mail at the beginning of the receive workflow, not inside object handlers 2019-01-04 13:50:21 -08:00
stamp Fix a mail stamp issue with blocking reviewers 2018-02-13 17:56:21 -08:00
storage Fix PHP 8.1 "strlen(null)" exception when received email lacks From header 2024-03-31 15:21:11 +02:00
typeahead Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
util Remove product literal strings in "pht()", part 6 2022-04-25 12:22:28 -07:00
view Rename "MetaMTA" mail attachments and add more mail message objects 2019-01-04 15:23:44 -08:00
PhabricatorMetaMTAWorker.php Rebrand: Add "path" entries to PlatformSymbols 2023-08-18 02:00:41 -07:00