1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 18:52:42 +01:00
phorge-phorge/src/applications/calendar/query
epriestley 50e809e06f Fix an issue where recurring ghost events could go missing if queried with a limit
Summary:
Ref T11816. Depends on D17644. When you executed a query like "upcoming, limit 5 events" you might match some recurring events starting from, say, a year ago and repeating every month.

We'd then generate the first 5 ghosts for these events (say, last January, February, ... May) and later throw them out, so the correct events in the query window (say, this April) would never get generated.

Instead, generate ghosts beginning with the start of the window. The fix in D17644 to number results correctly allows us to do this.

Test Plan:
  - Made a query panel showing 5 events, scheduled an event long in the past, did not visit any of the instances of it so they didn't generate concrete objects.
  - Before the patch, near-future instances failed to show; after the patch, they show.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11816

Differential Revision: https://secure.phabricator.com/D17645
2017-04-10 08:48:21 -07:00
..
PhabricatorCalendarEventInviteeQuery.php Fixing strictly null checks in CalendarInviteeQuery 2015-04-29 13:56:26 -07:00
PhabricatorCalendarEventQuery.php Fix an issue where recurring ghost events could go missing if queried with a limit 2017-04-10 08:48:21 -07:00
PhabricatorCalendarEventSearchEngine.php In Calendar mobile month view, color circles green for attending events too 2016-11-18 11:56:40 -08:00
PhabricatorCalendarEventTransactionQuery.php T5464, ApplicationTransactions for calendar events 2015-04-28 06:26:48 -07:00
PhabricatorCalendarExportQuery.php Export recurring events and build ICS files for configured exports 2016-10-06 14:07:17 -07:00
PhabricatorCalendarExportSearchEngine.php Reduce application search engine results list for Dashboards 2017-02-22 12:42:43 -08:00
PhabricatorCalendarExportTransactionQuery.php Make more of the Calendar export workflow work 2016-10-06 04:14:29 -07:00
PhabricatorCalendarExternalInviteeQuery.php Support arbitary event invitees when importing events 2016-10-27 13:27:58 -07:00
PhabricatorCalendarImportLogQuery.php Add import log messages to Calendar imports 2016-10-14 07:57:48 -07:00
PhabricatorCalendarImportLogSearchEngine.php Reduce application search engine results list for Dashboards 2017-02-22 12:42:43 -08:00
PhabricatorCalendarImportQuery.php Make Calendar ICS imports sort of work in a crude, approximate way 2016-10-12 15:29:05 -07:00
PhabricatorCalendarImportSearchEngine.php Reduce application search engine results list for Dashboards 2017-02-22 12:42:43 -08:00
PhabricatorCalendarImportTransactionQuery.php Prepare for event imports in Calendar 2016-10-12 10:45:31 -07:00