1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 15:52:41 +01:00
phorge-phorge/src/applications
epriestley 9eb285f4aa Fix "left"/"right" changeset ID selection for synthetic deletions
Summary:
Fixes T8323. See that task for a description.

We were using `nonempty()`, but that rule doesn't cover synthetic deletions (file present in an earlier diff, but no longer present in the later diff).

Test Plan: Followed the steps in T8323, got a clean comment.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8323

Differential Revision: https://secure.phabricator.com/D17929
2017-05-17 08:54:13 -07:00
..
almanac Cache Almanac URIs for repositories 2016-12-06 09:14:45 -08:00
aphlict Discard stdout/stderr from the aphlict subprocess when running in daemon (normal) mode 2016-11-13 16:43:42 -08:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Fix some error log issues with uninitialized commit/revision lists 2017-05-14 13:28:02 -07:00
auth Dirty the SSH key cache when usernames change 2017-04-14 08:03:00 -07:00
badges Spelling fix 2017-04-25 12:19:27 -07:00
base Make passing an object to newCurtain optional 2017-05-16 08:51:05 -07:00
cache With APCu 5+, use apcu_* function to examine cache state 2017-01-12 15:59:44 -08:00
calendar Fix two Calendar availability cache issues 2017-05-01 10:43:51 -07:00
celerity Make "Range" HTTP header work for Celerity static resource requests 2017-04-18 13:46:27 -07:00
chatlog Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
conduit Provide a hint that submitting a Conduit call shows you how to encode particular parameters 2017-03-24 13:15:03 -07:00
config Add "%I" (instance name) to application log formats 2017-04-23 11:07:19 -07:00
conpherence Mark ConpherenceCreate and Update conduit calls as frozen 2017-05-01 09:59:38 -07:00
console After a reconnect, repaint Conpherence thread state 2017-04-17 16:00:32 -07:00
countdown Remove old Countdown route 2017-04-13 13:04:55 -07:00
daemon Give Daemons a mobile menu 2017-03-24 09:19:56 -07:00
dashboard Provide a 'no dashboards' fallback state if you can't add any 2017-03-21 11:43:02 -07:00
differential Fix "left"/"right" changeset ID selection for synthetic deletions 2017-05-17 08:54:13 -07:00
diffusion Move most Differetial keyboard shortcuts into DiffChangesetList 2017-05-16 06:24:42 -07:00
diviner Fix a constant typo in Diviner ("DECLARATAION" -> "TION") 2017-03-04 09:54:10 -08:00
doorkeeper Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
draft/storage Clean up some log spam caused by races in VersionedDraft 2016-09-05 13:01:53 -07:00
drydock Fix 4 typos in code 2017-04-07 04:09:56 -07:00
fact Update Facts for newPage 2016-04-03 15:07:52 -07:00
favorites Add some style to label in Favorites Menu 2017-02-01 07:20:31 -08:00
feed Prevent media from autoplaying when rendered as a feed story 2016-11-22 14:19:56 -08:00
files Update Maniphest for modular transactions 2017-05-15 10:29:06 -07:00
flag Remove counts from home navigation 2017-01-21 13:55:40 -08:00
fund Fix FundRefund transaction calls 2017-05-09 09:59:41 -07:00
guides Add a bunch of Phacility-specific code to the upstream, thinly veiled as generic code 2016-11-15 09:11:22 -08:00
harbormaster Fix 4 typos in code 2017-04-07 04:09:56 -07:00
help Redesign header menus and search 2017-01-17 12:13:06 -08:00
herald Reduce application search engine results list for Dashboards 2017-02-22 12:42:43 -08:00
home Fix italics issue with nux state on homepage 2017-02-25 15:30:17 -08:00
legalpad Fix a runaway indentation level in LegalpadDocumentEditEngine 2017-05-14 13:59:57 -07:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Add Conduit edit endpoint for Macro 2017-05-10 14:54:43 -07:00
maniphest Set an icon for Maniphest story points 2017-05-16 12:44:28 -07:00
meta In Applications, always redirect back to the detail page after edits 2017-05-14 14:01:01 -07:00
metamta Explicitly quote "From" name part when submitting mail to the Mailgun API 2017-05-04 17:03:26 -07:00
multimeter Add a cluster.read-only option 2016-04-09 13:40:47 -07:00
notification Fix several duplication/replay behaviors in Aphlict 2017-04-18 12:10:12 -07:00
nuance Update Maniphest for modular transactions 2017-05-15 10:29:06 -07:00
oauthserver Reduce application search engine results list for Dashboards 2017-02-22 12:42:43 -08:00
owners Allow Owners packages to have arbitrarily long names 2017-04-27 18:04:03 -07:00
packages Fixing copy/paste mistake 2017-04-19 15:48:59 -07:00
passphrase Clean up some Passphrase transaction bugs 2017-05-08 15:55:50 -07:00
paste Fix bad "editPolicy" key in Paste 2017-04-05 13:09:51 -07:00
people Use grey dots for disabled users, even if a user is also unverified 2017-04-30 13:10:00 -07:00
phame Fix missing transaction constants in Phame 2017-05-12 19:04:16 +00:00
phid Use violet with not-verified user tags 2017-04-13 12:19:49 -07:00
phlux Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
pholio Migrate Pholio inline comments to modular transactions 2017-05-16 12:22:46 -07:00
phortune Restrict PhortuneMerchant creation at EditEngine level 2017-05-08 15:56:07 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Remove PhabricatorFile::buildFromFileDataOrHash() 2017-04-04 16:18:00 -07:00
phrequent Allow Phrequent to be used in dashboard panels 2017-03-06 11:00:55 -08:00
phriction Move Phriction MOVE_TO transaction to Modular Transactions 2017-05-16 15:52:35 -07:00
phurl Change PhabricatorPhurlURLViewController to use EditEngine for commenting 2017-04-17 10:19:21 -07:00
policy Implement modular transactions for application policy changes 2017-05-03 17:49:41 -07:00
ponder Fix PonderAnswer transaction callsite 2017-05-12 19:04:48 +00:00
project Normalize headers and actions in Project sub pages 2017-05-16 09:58:33 -07:00
releeph Replace Remarkup calls to PhabricatorHash::digest() with SHA256 2017-04-06 15:43:18 -07:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository Update Maniphest for modular transactions 2017-05-15 10:29:06 -07:00
search Stem fulltext tokens before filtering them for stopwords 2017-04-19 10:02:21 -07:00
settings Add some basic sound preferences 2017-04-19 13:04:02 -07:00
slowvote Make a handful of minor Slowvote behaviors more consistent with other applications 2017-05-14 14:01:33 -07:00
spaces Update Spaces for modular transactions 2017-05-04 21:48:13 +00:00
subscriptions Clean up some rough Macro transaction edges 2017-05-08 16:29:35 -07:00
support/application
system Disallow /source/ in robots.txt 2017-04-06 16:28:09 -07:00
tokens Prevent awarding/revoking tokens when a task is locked 2017-03-04 09:55:35 -08:00
transactions Move Phriction Title transaction to Modular Transactions 2017-05-16 11:08:38 -07:00
typeahead Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
uiexample Fix two typos ("Adminstrator", "Recipents") 2017-03-12 14:23:43 -07:00
xhprof Allow XHProf profiles to be drag-and-dropped to upload them 2017-02-23 11:16:19 -08:00