1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 11:30:55 +01:00
phorge-phorge/src/applications/herald
epriestley c9a0d68340 Allow Herald rules to add comments
Summary:
See PHI242. All use cases for this that I know of are pretty hacky, but they don't seem perilous, and it's easier than webhooks.

See P1895, T10183, and T9853 for me previously refusing to implement this since all those use cases were also pretty bad.

Test Plan:
  - Wrote a rule to add comments, saw it add comments.
  - Reviewed summary, re-edited rule, reviewed transcript to check that all the strings worked OK.
  - Wrote a new rule for a non-commentable object (a blog) to make sure I wasn't offered the "Add a comment" action.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18823
2017-12-18 09:10:57 -08:00
..
action Allow Herald rules to add comments 2017-12-18 09:10:57 -08:00
adapter Don't run Herald build and mail rules when they don't make sense 2017-10-27 08:44:12 -07:00
application Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
config Extend from Phobject 2015-06-15 18:02:27 +10:00
contentsource Modularize content sources 2016-03-26 11:59:45 -07:00
controller Don't run Herald build and mail rules when they don't make sense 2017-10-27 08:44:12 -07:00
editor Drive Herald edits via transactions 2016-03-28 23:02:41 +00:00
engine Don't run Herald build and mail rules when they don't make sense 2017-10-27 08:44:12 -07:00
engineextension Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
field Don't run Herald build and mail rules when they don't make sense 2017-10-27 08:44:12 -07:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
group Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
phid In Remarkup, render archived Herald rules with strikethrough for consistency 2016-12-08 12:37:54 -08:00
query Reduce application search engine results list for Dashboards 2017-02-22 12:42:43 -08:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
state Don't run Herald build and mail rules when they don't make sense 2017-10-27 08:44:12 -07:00
storage Don't run Herald build and mail rules when they don't make sense 2017-10-27 08:44:12 -07:00
typeahead Search builds based on who kicked them off 2016-07-31 20:54:44 +00:00
value Allow Herald rules to add comments 2017-12-18 09:10:57 -08:00