revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-28 16:30:59 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/view/form/control
History
epriestley b62420e6e4 Separate reading object values out of didSetObject() in CustomField 
Summary:
Ref T3886. Broadly, fields break down into two types right now: fields which store data on the object (like `DifferentialTitleField`) and fields which store data in custom field storage.

The former type generally reads data from the object into local storage prior to editing, then writes it back afterward. Currently, this happens in `didSetObject()`.

However, now that we load and set objects from ApplicationTransactionQuery, we'll do this extra read-field-values on view interfaces too. There, it's unnecessary and sometimes throws data-attached exceptions.

Instead, separate these concepts, and do all the read-from-object / read-from-storage in one logical chunk, separate from `didSetObject()`.

Test Plan:
  - Edited Differential revision.
  - Edited Maniphest task.
  - Edited Project.
  - Edited user profile.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3886

Differential Revision: https://secure.phabricator.com/D8299
2014-02-21 14:44:01 -08:00
..
AphrontFormCheckboxControl.php Replace some hsprintf() with phutil_tag() and phutil_tag_div() Depends on D7545. 2013-11-09 10:48:19 -08:00
AphrontFormControl.php Move "Remote URI" to modern repository editor thing 2013-10-25 13:59:02 -07:00
AphrontFormCropControl.php Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
AphrontFormDateControl.php Use ApplicationSearch in the calendar event list view 2014-02-06 10:10:18 -08:00
AphrontFormDividerControl.php Convert AphrontFormControl to safe HTML 2013-02-05 15:52:46 -08:00
AphrontFormFileControl.php Convert phutil_render_tag(X, Y) to phutil_tag 2013-01-24 19:08:54 -08:00
AphrontFormImageControl.php pht() for view and form elements 2013-03-01 15:37:33 -08:00
AphrontFormMarkupControl.php Delete license headers from files 2012-11-05 11:16:51 -08:00
AphrontFormPasswordControl.php Convert phutil_render_tag(X, Y) to phutil_tag 2013-01-24 19:08:54 -08:00
AphrontFormPolicyControl.php Separate reading object values out of didSetObject() in CustomField 2014-02-21 14:44:01 -08:00
AphrontFormRadioButtonControl.php Replace some hsprintf() with phutil_tag() and phutil_tag_div() Depends on D7545. 2013-11-09 10:48:19 -08:00
AphrontFormRecaptchaControl.php Convert AphrontFormControl to safe HTML 2013-02-05 15:52:46 -08:00
AphrontFormSelectControl.php render_tag -> tag: forms / remarkup 2013-02-02 06:04:54 -08:00
AphrontFormStaticControl.php Convert AphrontFormControl to safe HTML 2013-02-05 15:52:46 -08:00
AphrontFormSubmitControl.php pht() for view and form elements 2013-03-01 15:37:33 -08:00
AphrontFormTextAreaControl.php Add JS support for replacing Pholio mocks 1:1 2013-07-19 14:07:22 -07:00
AphrontFormTextControl.php Fix whitespace around methods 2013-04-23 09:42:35 -07:00
AphrontFormTextWithSubmitControl.php Clean up the Diffusion search UI a little bit 2014-02-01 11:48:28 -08:00
AphrontFormToggleButtonsControl.php Convert AphrontFormControl to safe HTML 2013-02-05 15:52:46 -08:00
AphrontFormTokenizerControl.php Make projects appear in all mailable tokenizers 2014-02-18 16:32:41 -08:00
PhabricatorRemarkupControl.php Decentralize phtize 2013-11-04 11:38:28 -08:00
PHUIFormDividerControl.php Add instructions about READMEs to new Diffusion basic editor 2013-05-24 12:38:27 -07:00
PHUIFormFreeformDateControl.php Add a date range query to Macros 2013-05-30 17:32:12 -07:00
PHUIFormMultiSubmitControl.php Basic filename search support for Diffusion 2014-02-01 08:33:03 -08:00