1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00
phorge-phorge/src/view
epriestley a4a9485612 Hide dropdown menus when users click workflow items
Summary:
In D16157, dropdown menus got an overly-broad check for not closing when an item is clicked.

Specifically, we don't want to close the menu if the item is really opening a submenu, like "Edit Related Objects..." does on mobile.

The check for this is too broad, and also doesn't close the menu if the item has workflow.

Instead, use a narrower check.

Test Plan:
  - Menu still stays open when toggling submenus like "Edit Related Objects".
  - Menu now closes properly when using workflow items like "Edit Comment" or "Remove Comment".

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17210
2017-01-16 13:38:12 -08:00
..
__tests__ Fix local time test case for logged-out viewers using global settings 2016-11-28 09:27:11 -08:00
control Redesign Application Search 2016-08-01 12:23:36 -07:00
extension Introduce "Curtain" views, panels, and extensions 2016-03-06 09:27:55 -08:00
form Allow any EditEngine comment form to be pinned 2016-12-29 12:49:18 -08:00
layout Hide dropdown menus when users click workflow items 2017-01-16 13:38:12 -08:00
page When a custom logo is configured but has a restrictive visibility policy, fall back to the default logo 2016-12-09 07:50:59 -08:00
phui Reorganize phui-object-item CSS, add drag ui 2016-12-14 11:53:17 -08:00
widget Move PhabricatorHovercard to PHUIHovercard 2016-02-03 16:26:30 +00:00
AphrontDialogView.php Allow dialogs to opt in to being resizable 2016-06-20 19:13:58 -07:00
AphrontJavelinView.php Various linter fixes 2015-05-20 07:27:41 +10:00
AphrontNullView.php Provide hasChildren() to replace isEmptyContent() 2013-08-12 07:51:01 -07:00
AphrontTagView.php Remove extra container tag on HandleListViews rendering from ModularTransactions in text mode 2017-01-09 08:41:59 -08:00
AphrontView.php Give AphrontTagView a getViewer(), deprecate getUser() 2016-03-06 09:27:38 -08:00
viewutils.php Continue modernizing application access to user preferences 2016-06-04 14:37:56 -07:00