1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-25 06:50:55 +01:00
phorge-phorge/src/view/layout
epriestley a4a9485612 Hide dropdown menus when users click workflow items
Summary:
In D16157, dropdown menus got an overly-broad check for not closing when an item is clicked.

Specifically, we don't want to close the menu if the item is really opening a submenu, like "Edit Related Objects..." does on mobile.

The check for this is too broad, and also doesn't close the menu if the item has workflow.

Instead, use a narrower check.

Test Plan:
  - Menu still stays open when toggling submenus like "Edit Related Objects".
  - Menu now closes properly when using workflow items like "Edit Comment" or "Remove Comment".

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17210
2017-01-16 13:38:12 -08:00
..
__tests__ Mark some strings for translation 2015-06-09 23:06:52 +10:00
AphrontListFilterView.php Minor formatting changes 2014-10-08 08:39:49 +11:00
AphrontMoreView.php phtize all the things 2015-05-22 21:16:39 +10:00
AphrontMultiColumnView.php phtize all the things 2015-05-22 21:16:39 +10:00
AphrontSideNavFilterView.php Use new Guide layout in Config->Welcome 2016-09-03 07:32:22 -07:00
PhabricatorActionListView.php Fold task-relationship actions into an accordion dropdown 2016-06-20 19:14:27 -07:00
PhabricatorActionView.php Hide dropdown menus when users click workflow items 2017-01-16 13:38:12 -08:00
PhabricatorAnchorView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
PhabricatorFileLinkView.php Add download link to embedded files 2017-01-03 10:50:26 -08:00
PhabricatorSourceCodeView.php Truncate long source lines in Paste search result list snippets 2015-10-20 19:07:04 +00:00
PHUIApplicationMenuView.php Allow profile menus to be collapsed and expanded 2016-01-19 13:16:54 -08:00
PHUICurtainPanelView.php Introduce "Curtain" views, panels, and extensions 2016-03-06 09:27:55 -08:00
PHUICurtainView.php Convert Maniphest to curtain view 2016-03-06 10:32:18 -08:00