1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/subscriptions
epriestley 0e7a5623e3 Allow task statuses to "lock" them, preventing additional comments and interactions
Summary:
Ref T12335. See that task for discussion. Here are the behavioral changes:

  - Statuses can be flagged with `locked`, which means that tasks in that status are locked to further discussion and interaction.
  - A new "CAN_INTERACT" permission facilitates this. For most objects, "CAN_INTERACT" is just the same as "CAN_VIEW".
  - For tasks, "CAN_INTERACT" is everyone if the status is a normal status, and no one if the status is a locked status.
  - If a user doesn't have "Interact" permission:
    - They can not submit the comment form.
    - The comment form is replaced with text indicating "This thing is locked.".
    - The "Edit" workflow prompts them.

This is a mixture of advisory and hard policy checks but sholuld represent a reasonable starting point.

Test Plan: Created a new "Locked" status, locked a task. Couldn't comment, saw lock warning, saw lock prompt on edit. Unlocked a task.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12335

Differential Revision: https://secure.phabricator.com/D17453
2017-03-02 16:57:10 -08:00
..
application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
command phtize all the things 2015-05-22 21:16:39 +10:00
controller Allow task statuses to "lock" them, preventing additional comments and interactions 2017-03-02 16:57:10 -08:00
editor Modularize SearchEngine extensions 2015-12-14 04:23:02 -08:00
engineextension Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
events Allow task statuses to "lock" them, preventing additional comments and interactions 2017-03-02 16:57:10 -08:00
herald Various translation improvements 2015-11-03 07:02:46 +11:00
interface Remove shouldShowSubscribersProperty() from SubscribableInterface 2016-03-06 06:01:36 -08:00
policyrule Add a "Subscribers" object policy 2015-06-13 15:45:17 -07:00
query Modernize remaining edge types 2015-01-03 10:58:20 +11:00
view Show hovercards for most links in object property views 2015-12-24 12:10:56 -08:00