1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
phorge-phorge/src/infrastructure
epriestley 9502312b60 Remove "final" from "private" methods in Phabricator
Summary:
Ref T13588. This has never been meaningful, but a "final private" method is specifically forbidden in PHP8.

Remove meaningless "final" from these methods, per new lint checks.

Test Plan: Ran `arc lint --everything` to identify affected methods, then `... | xargs -n1 arc lint --apply-patches`.

Maniphest Tasks: T13588

Differential Revision: https://secure.phabricator.com/D21540
2021-02-03 14:13:29 -08:00
..
cache Use "@" to silence "GC list" warnings from "apc_store()" and "apcu_store()" 2020-04-28 04:13:37 -07:00
cluster Fix additional "xprintf()"-class static parameter lint errors 2020-09-08 11:45:48 -07:00
contentsource Redesign Config Application 2016-08-29 15:49:49 -07:00
customfield Fix additional "xprintf()"-class static parameter lint errors 2020-09-08 11:45:48 -07:00
daemon Add "bin/worker delay" and "bin/worker priority" utilities for managing task queues 2021-02-02 13:40:11 -08:00
diff When a new, deleted, draft inline is revived with "Undo", undelete it 2020-10-19 12:34:03 -07:00
edges Fix an issue where loading a mangled project graph could fail too abruptly 2020-02-03 08:54:04 -08:00
editor Restore editor behavior to Diffusion and support "\" shortcut 2020-04-19 09:41:37 -07:00
env Make it easier to parse "X-Forwarded-For" with one or more load balancers 2019-09-05 04:30:13 -07:00
events Remove "PhabricatorEventType::TYPE_DIFFUSION_LOOKUPUSER" event 2019-11-19 09:38:03 -08:00
export Export "date" and "remarkup" custom fields to Excel + "zip" extension check 2019-07-18 09:59:20 -07:00
graph Set an explicit height when drawing the dependent revision graph 2020-10-16 14:10:36 -07:00
internationalization Add "bin/worker delay" and "bin/worker priority" utilities for managing task queues 2021-02-02 13:40:11 -08:00
javelin When printing timestamps on paper: use an absolute, context-free date format 2020-09-04 16:36:34 -07:00
lint/linter Linter fixes 2015-12-03 07:44:23 +11:00
lipsum Continue moving classes with no callers in libphutil or Arcanist to Phabricator 2020-02-12 13:14:04 -08:00
log Proxy the "git upload-pack" wire protocol 2019-04-18 04:57:51 -07:00
management Add additional flags to "bin/repository rebuild-identities" to improve flexibility 2019-11-19 09:39:48 -08:00
markup Support "control" and "return/enter" in the remarkup rule for keystrokes 2021-01-11 19:47:40 -08:00
parser Continue moving classes with no callers in libphutil or Arcanist to Phabricator 2020-02-12 13:14:04 -08:00
query Remove "final" from "private" methods in Phabricator 2021-02-03 14:13:29 -08:00
ssh Generate a random unique "Request ID" for SSH requests so processes can coordinate better 2018-03-22 13:44:30 -07:00
status Give Drydock Leases more modern status treatment 2018-02-13 13:15:57 -08:00
storage Remove "final" from "private" methods in Phabricator 2021-02-03 14:13:29 -08:00
syntax Pass the new default syntax highlighting map to the remarkup engine 2016-05-05 02:51:19 -07:00
testing When running unit tests, ignore any custom task fields 2017-04-02 09:36:17 -07:00
time Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles"). 2019-05-30 15:03:11 -07:00
util When acquiring a GlobalLock, put good connections that just got unlucky back in the pool 2020-06-25 18:06:09 -07:00
PhabricatorEditor.php Mark some strings for translation 2015-06-09 23:06:52 +10:00