revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 23:32:40 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley a7c008708d Correct a mangled translation string in "bin/phd log --id X" 
Summary:
Ref T13210. See PHI930. This translation is wrong: the parameter is a comma-separated list as a string, but the USEnglish translation provides alternatives. We can't select among alternatives based on a random string (it isn't a plurality value to let us select "chair" vs "chairs", and isn't a gender value to let us select "his profile" vs "her profile") so we get an error.

But the string itself is also misleading, since "bin/phd log --id A --id B --id C" will say "none of these are valid" if //any// of them are invalid.

Instead, just tell the user explicitly about the first problem.

Test Plan:
  - Ran `bin/phd log --id` with good (got logs) and bad IDs (got sensible error).
  - Ran `bin/phd log` with any logs (got logs) and (simluated) without any logs (got error).

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13210

Differential Revision: https://secure.phabricator.com/D19755
2018-10-26 06:13:18 -07:00
..
almanac When cancelling addition of an Almanac interface, return to the Device page 2018-08-13 11:39:37 -07:00
aphlict minor: fix translation error in exception 2018-06-04 17:46:13 +00:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Enrich "diffusion.commit.search" with identity, status, and message information 2018-09-12 12:45:44 -07:00
auth Add 'autocomplete="off"' to MFA TOTP inputs 2018-10-01 13:08:54 -07:00
badges Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
base Revert the alternate menu names for applications 2018-04-08 10:20:24 -07:00
cache Improve compatibility of "Config > Cache Status" across APCu versions 2018-08-08 15:07:03 -07:00
calendar Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
celerity Emit a "Content-Security-Policy" HTTP header 2018-02-27 10:17:30 -08:00
chatlog Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
conduit Make DiffusionCommitSearch accept modern (string) constants 2018-09-10 16:25:42 -07:00
config Remove another old remarkup engine callsite in Config 2018-08-27 11:10:14 -07:00
conpherence Remove requireCapabilities() from ApplicationTransactionEditor and require CAN_EDIT by default 2018-08-24 17:45:56 -07:00
console Fix some minor errors (DarkConsole warning, unstable Ferret sort) 2018-03-18 15:12:25 -07:00
countdown Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
daemon Correct a mangled translation string in "bin/phd log --id X" 2018-10-26 06:13:18 -07:00
dashboard Make the dashboard panel datasource work properly with hundreds of panels 2018-06-28 08:54:29 -07:00
differential Skip copied code detection for changes that are too large for it to be useful 2018-10-20 03:36:34 -07:00
diffusion Explicitly shuffle nodes before selecting one for cluster sync 2018-10-17 08:11:23 -07:00
diviner Rename "PHUIDocumentViewPro" to "PHUIDocumentView" 2018-08-28 14:53:07 -07:00
doorkeeper Allow Doorkeeper references to have multiple display variations (full, short, etc.) 2018-03-13 11:29:52 -07:00
draft/storage When purging drafts after a transaction edit, purge all drafts 2018-02-11 06:01:09 -08:00
drydock Expose Drydock leases via Conduit 2018-10-26 06:12:38 -07:00
fact Fix some of the most obvious bugs in fact generation from Maniphest tasks 2018-02-19 12:07:28 -08:00
favorites Add some missing aural button labels for accessibility 2018-08-17 11:00:29 -07:00
feed Add a rough "bin/repository unpublish" workflow to attempt to cleanup improperly published repositories 2018-03-30 08:46:11 -07:00
files Stop indexing the chunk data objects for large Files stored in multiple chunks 2018-08-03 14:36:12 -07:00
flag Remove counts from home navigation 2017-01-21 13:55:40 -08:00
fund Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
guides Rename "PHUIDocumentViewPro" to "PHUIDocumentView" 2018-08-28 14:53:07 -07:00
harbormaster Allow underscores to appear in Harbormaster variable names 2018-09-07 09:53:59 -07:00
help Redesign header menus and search 2017-01-17 12:13:06 -08:00
herald Support querying Herald rules by monogram in typeahead datsources 2018-08-01 17:52:27 -07:00
home Update menu item names for Applications -> Favorites 2017-09-05 19:05:03 -07:00
legalpad Rename "PHUIDocumentViewPro" to "PHUIDocumentView" 2018-08-28 14:53:07 -07:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Make the meme cache case-sensitive 2018-07-26 12:15:32 -07:00
maniphest Enrich "priority" transactions in Maniphest for "transaction.search" 2018-08-24 10:05:05 -07:00
meta Rename "PHUIDocumentViewPro" to "PHUIDocumentView" 2018-08-28 14:53:07 -07:00
metamta Fix packages(project) to work properly and add it to "MailableFunctionDatasource" 2018-10-19 13:53:27 -07:00
multimeter Add a cluster.read-only option 2016-04-09 13:40:47 -07:00
notification Fix the most significant "phantom notification" badness 2018-04-19 17:24:19 -07:00
nuance Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
oauthserver Remove client OAuth redirect code which was only partially cleaned up 2018-03-06 20:41:13 -08:00
owners Fix packages(project) to work properly and add it to "MailableFunctionDatasource" 2018-10-19 13:53:27 -07:00
packages Fixing copy/paste mistake 2017-04-19 15:48:59 -07:00
passphrase Fix spelling 2017-10-09 10:48:04 -07:00
paste Fix Lipsum generators for Differential Revisions and Pastes 2018-07-23 15:05:51 -05:00
people When a user takes actions while in a high security session, note it on the resulting transactions 2018-09-12 12:57:02 -07:00
phame Rename "PHUIDocumentViewPro" to "PHUIDocumentView" 2018-08-28 14:53:07 -07:00
phid Truncate package names in diff table of contents views 2018-06-07 13:17:01 -07:00
phlux Add edge tables for Phlux 2018-04-19 15:49:08 -07:00
pholio Make Pholio mail render without a ton of over-escaped HTML 2018-10-05 13:37:26 -07:00
phortune Add card expiration information to Phortune cart screen 2018-06-02 18:23:44 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Remove PhabricatorFile::buildFromFileDataOrHash() 2017-04-04 16:18:00 -07:00
phrequent Fix spelling 2017-10-09 10:48:04 -07:00
phriction Fix Phriction rendering for initial install and 404 pages 2018-09-17 20:02:59 -07:00
phurl Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
policy Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults 2018-04-27 16:56:11 -07:00
ponder Make Facts more modern, DRY, and dimensional 2018-02-19 12:05:19 -08:00
project Remove requireCapabilities() from ApplicationTransactionEditor and require CAN_EDIT by default 2018-08-24 17:45:56 -07:00
releeph Mostly modularize the Differential "update" transaction 2018-03-06 09:10:32 -08:00
remarkup/conduit
repository Try to route cluster writes to nodes which won't need to synchronize first 2018-10-17 08:08:25 -07:00
search Make DiffusionCommitSearch accept modern (string) constants 2018-09-10 16:25:42 -07:00
settings Make the filetree view width sticky across show/hide and reload 2018-02-22 13:47:41 -08:00
slowvote Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
spaces Add more mail stamps: tasks, subscribers, projects, spaces 2018-02-06 04:05:46 -08:00
subscriptions Remove requireCapabilities() from ApplicationTransactionEditor and require CAN_EDIT by default 2018-08-24 17:45:56 -07:00
support/application
system Add a generic PHID-based object redirection controller 2018-06-12 11:54:59 -07:00
tokens Property list view on Diffusion commits should show build status but not Subscriptions, Projects, or Tokens 2017-12-01 18:16:26 +00:00
transactions In "bin/bulk export", require "--output <path>" by default 2018-10-11 13:35:16 -07:00
typeahead Rename "PHUIDocumentViewPro" to "PHUIDocumentView" 2018-08-28 14:53:07 -07:00
uiexample Reduce the cost of generating default user profile images 2018-03-01 16:53:17 -08:00
xhprof Allow XHProf profiles to be drag-and-dropped to upload them 2017-02-23 11:16:19 -08:00