1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-02 01:48:23 +01:00
phorge-phorge/src/applications/daemon/management
epriestley a7c008708d Correct a mangled translation string in "bin/phd log --id X"
Summary:
Ref T13210. See PHI930. This translation is wrong: the parameter is a comma-separated list as a string, but the USEnglish translation provides alternatives. We can't select among alternatives based on a random string (it isn't a plurality value to let us select "chair" vs "chairs", and isn't a gender value to let us select "his profile" vs "her profile") so we get an error.

But the string itself is also misleading, since "bin/phd log --id A --id B --id C" will say "none of these are valid" if //any// of them are invalid.

Instead, just tell the user explicitly about the first problem.

Test Plan:
  - Ran `bin/phd log --id` with good (got logs) and bad IDs (got sensible error).
  - Ran `bin/phd log` with any logs (got logs) and (simluated) without any logs (got error).

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13210

Differential Revision: https://secure.phabricator.com/D19755
2018-10-26 06:13:18 -07:00
..
PhabricatorDaemonManagementDebugWorkflow.php Add "--pool" and "--duration" flags to daemon CLI tools 2017-02-28 07:43:46 -08:00
PhabricatorDaemonManagementLaunchWorkflow.php Update phd launch 2017-03-02 21:37:02 +11:00
PhabricatorDaemonManagementListWorkflow.php Fix visibility of PhutilArgumentWorkflow::didConstruct methods 2015-01-16 07:42:07 +11:00
PhabricatorDaemonManagementLogWorkflow.php Correct a mangled translation string in "bin/phd log --id X" 2018-10-26 06:13:18 -07:00
PhabricatorDaemonManagementReloadWorkflow.php phtize all the things 2015-05-22 21:16:39 +10:00
PhabricatorDaemonManagementRestartWorkflow.php Fix errors found by PHPStan 2017-02-18 09:24:56 +00:00
PhabricatorDaemonManagementStartWorkflow.php Fix errors found by PHPStan 2017-02-18 09:24:56 +00:00
PhabricatorDaemonManagementStatusWorkflow.php phtize all the things 2015-05-22 21:16:39 +10:00
PhabricatorDaemonManagementStopWorkflow.php phtize all the things 2015-05-22 21:16:39 +10:00
PhabricatorDaemonManagementWorkflow.php Update Phabricator for new daemon pool changes 2017-02-22 13:15:14 -08:00
PhabricatorLockLogManagementWorkflow.php Add a "lock log" for debugging where locks are being held 2018-03-05 17:55:34 -08:00
PhabricatorLockManagementWorkflow.php Add a "lock log" for debugging where locks are being held 2018-03-05 17:55:34 -08:00