1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 17:22:42 +01:00
phorge-phorge/src/infrastructure
epriestley a7c008708d Correct a mangled translation string in "bin/phd log --id X"
Summary:
Ref T13210. See PHI930. This translation is wrong: the parameter is a comma-separated list as a string, but the USEnglish translation provides alternatives. We can't select among alternatives based on a random string (it isn't a plurality value to let us select "chair" vs "chairs", and isn't a gender value to let us select "his profile" vs "her profile") so we get an error.

But the string itself is also misleading, since "bin/phd log --id A --id B --id C" will say "none of these are valid" if //any// of them are invalid.

Instead, just tell the user explicitly about the first problem.

Test Plan:
  - Ran `bin/phd log --id` with good (got logs) and bad IDs (got sensible error).
  - Ran `bin/phd log` with any logs (got logs) and (simluated) without any logs (got error).

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13210

Differential Revision: https://secure.phabricator.com/D19755
2018-10-26 06:13:18 -07:00
..
cluster Allow mailers to be explicitly marked as inbound or outbound 2018-07-30 08:25:06 -07:00
contentsource Redesign Config Application 2016-08-29 15:49:49 -07:00
customfield Provide comment actions for tokenizer custom fields 2018-03-29 14:10:15 -07:00
daemon Add a "lock log" for debugging where locks are being held 2018-03-05 17:55:34 -08:00
diff When authors add inlines to their own revisions/commits, mark them as "Done" by default 2018-09-07 11:18:14 -07:00
edges Add a bit of test coverage for bulky vs compact edge data representations 2018-01-29 11:34:57 -08:00
env When building a config stack, stop SiteSource objects from poisoning the cache 2018-07-20 16:07:41 -07:00
events Modernize Hovercard implementation 2015-12-24 12:18:28 -08:00
export Allow "bin/bulk export" to merge multiple queries and accept more flexible flags 2018-10-10 09:14:14 -07:00
graph Enable hovercards for the "Task Graph" UI in Maniphest 2017-10-04 11:12:01 -07:00
internationalization Correct a mangled translation string in "bin/phd log --id X" 2018-10-26 06:13:18 -07:00
javelin When the profiler is active, keep it active if the user submits forms 2017-02-23 11:15:40 -08:00
lint/linter Linter fixes 2015-12-03 07:44:23 +11:00
log Add "%I" (instance name) to application log formats 2017-04-23 11:07:19 -07:00
management Provide "bin/files integrity" for debugging, maintaining and backfilling integrity hashes 2017-04-06 15:42:43 -07:00
markup Fix YouTube remarkup rule being blocked by Content-Security-Policy header 2018-04-02 16:11:02 -07:00
query Support the Ferret "=" (exact match) operator in the actual query engine 2018-07-23 12:44:00 -07:00
sms Various linter fixes 2015-08-11 22:36:55 +10:00
ssh Generate a random unique "Request ID" for SSH requests so processes can coordinate better 2018-03-22 13:44:30 -07:00
status Give Drydock Leases more modern status treatment 2018-02-13 13:15:57 -08:00
storage Fix truncation in "bin/storage probe" of tables larger than 100GB 2018-08-08 09:50:59 -07:00
syntax Pass the new default syntax highlighting map to the remarkup engine 2016-05-05 02:51:19 -07:00
testing When running unit tests, ignore any custom task fields 2017-04-02 09:36:17 -07:00
time Fix errors found by PHPStan 2017-02-18 09:24:56 +00:00
util When we fail to acquire a repository lock, try to provide a hint about why 2018-09-24 15:20:07 -07:00
PhabricatorEditor.php Mark some strings for translation 2015-06-09 23:06:52 +10:00