revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley a8c9a5597d Improve error and header behaviors for Mailgun received mail webhook 
Summary:
Ref T10709. Two issues:

  - If a user sends an invalid `!command`, we can throw, which means we don't return HTTP 200. This makes Mailgun re-send the mail later.
  - We don't parse headers of the modern API correctly, so the "Message-ID" failsafe doesn't work. Parse them correctly. I //believe// Mailgun's API changed at some point.

Test Plan:
This is difficult to test exhaustively in isolation. I used Mailgun's web tools to verify the format of the hook request, and faked some requests locally.

I'll keep an eye on this as it goes to production and make sure the fix is correct there.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10709

Differential Revision: https://secure.phabricator.com/D15575
2016-04-02 10:51:29 -07:00
..
almanac Update EditEngine for two column 2016-03-28 09:18:55 -07:00
aphlict Update "should not run as root" message 2015-10-31 11:20:23 +00:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Modularize content sources 2016-03-26 11:59:45 -07:00
auth Update Auth for new UI 2016-03-31 13:51:12 -07:00
badges Allow ordering of badges by quality 2016-04-01 12:00:13 -07:00
base Convert every two-column application except Maniphest to curtain views 2016-03-06 10:44:07 -08:00
cache Write 500 words on how to restart webservers 2015-12-02 09:16:10 -08:00
calendar Update Calendar Edit for new UI 2016-04-01 13:48:53 -07:00
celerity Polish up timeline for PHIUTwoColumnView 2016-03-08 17:51:53 -08:00
chatlog Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
conduit Modularize content sources 2016-03-26 11:59:45 -07:00
config Add amazon-ses.endpoint configuration 2016-03-23 12:28:59 -07:00
conpherence Modularize content sources 2016-03-26 11:59:45 -07:00
console Separate external editor integration from callsigns 2016-01-04 06:54:01 -08:00
countdown Update Countdown edit page for new UI 2016-04-01 14:13:58 +00:00
daemon Update Deamons with new UI 2016-04-02 10:41:01 -07:00
dashboard Expand scope of addActionItem in PHUIHeaderView 2016-03-04 18:35:05 -08:00
differential Fix javascript interaction with right-hand-side images in two-up diff views in Differential 2016-04-01 12:54:43 -07:00
diffusion Fix Diffusion blame columns when disabling blame 2016-03-26 12:06:37 -07:00
diviner Restrict PropertyListView width to just DocumentProView 2016-02-22 11:54:23 -08:00
doorkeeper Bridge GitHub users into Phabricator and attribute actions to them 2016-03-28 13:10:32 -07:00
draft/storage Fix EditEngine preview/draft for first comment on a task you didn't create 2015-12-05 09:57:45 -08:00
drydock Update EditEngine for two column 2016-03-28 09:18:55 -07:00
fact Swap charts from gRaphael to D3 2016-02-01 10:36:59 -08:00
feed Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
files Support pushing data into Git LFS 2016-03-18 09:36:34 -07:00
flag Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
fund Add commenting to Fund 2016-03-31 16:01:15 -07:00
harbormaster Update EditEngine for two column 2016-03-28 09:18:55 -07:00
help Begin modularizing main menu items 2016-01-04 06:57:09 -08:00
herald Update Herald edit/transcripts to modern UI 2016-04-01 14:14:25 +00:00
home Expand scope of addActionItem in PHUIHeaderView 2016-03-04 18:35:05 -08:00
legalpad Remove shouldShowSubscribersProperty() from SubscribableInterface 2016-03-06 06:01:36 -08:00
lipsum Modularize content sources 2016-03-26 11:59:45 -07:00
macro Update Macro Edit for new UI 2016-04-01 21:08:51 +00:00
maniphest Update EditEngine for two column 2016-03-28 09:18:55 -07:00
meta Update Meta for new UI 2016-04-01 14:13:16 -07:00
metamta Improve error and header behaviors for Mailgun received mail webhook 2016-04-02 10:51:29 -07:00
multimeter Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
notification Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
nuance Remove dedicated storage for NuanceRequestor 2016-03-29 08:53:35 -07:00
oauthserver Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
owners Update EditEngine for two column 2016-03-28 09:18:55 -07:00
passphrase Attach credential impelementations when initializing new credentials 2016-03-22 18:53:09 -07:00
paste Update EditEngine for two column 2016-03-28 09:18:55 -07:00
people Allow awarding Badges from the profile 2016-03-31 20:39:06 +00:00
phame Update EditEngine for two column 2016-03-28 09:18:55 -07:00
phid Bridge GitHub users into Phabricator and attribute actions to them 2016-03-28 13:10:32 -07:00
phlux Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
pholio Moderize Pholio UI 2016-04-01 12:29:32 -07:00
phortune Modularize content sources 2016-03-26 11:59:45 -07:00
phpast Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
phragment Moderize Phragment 2016-04-02 14:24:40 +00:00
phrequent Add a Phrequent curtain extension 2016-03-10 18:45:04 -08:00
phriction Update Phriction Edit/History/Diff UI 2016-04-02 14:26:19 +00:00
phurl When marking up Phurl URLs for mail, use absolute URLs 2016-03-18 16:00:31 -07:00
policy Simplify locking of Almanac cluster services 2016-02-25 03:38:39 -08:00
ponder Update misc bits of Ponder to TwoColumnView 2016-03-27 13:12:28 -07:00
project Change "Projects" to "Tags" for curtain extension 2016-04-01 07:20:32 -07:00
releeph Modularize content sources 2016-03-26 11:59:45 -07:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository Modularize content sources 2016-03-26 11:59:45 -07:00
search Update EditEngine for two column 2016-03-28 09:18:55 -07:00
settings Make temporary token storage/schema more flexible 2016-03-16 09:33:38 -07:00
slowvote Convert Slowvote Edit page to new UI 2016-03-31 19:06:59 -07:00
spaces Modularize content sources 2016-03-26 11:59:45 -07:00
subscriptions Introduce "Curtain" views, panels, and extensions 2016-03-06 09:27:55 -08:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
tokens Modularize content sources 2016-03-26 11:59:45 -07:00
transactions Update EditEngine for two column 2016-03-28 09:18:55 -07:00
typeahead Allow Almanac interfaces to be browsed 2016-02-21 10:45:00 -08:00
uiexample Update to use PHUIRemarkupView everywhere possible 2016-02-16 14:05:53 -08:00
xhprof Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00