1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-21 13:00:56 +01:00
phorge-phorge/src/applications/herald
epriestley fbfcc37531 Respect token limits for "Assign to" and custom datasource fields in Herald
Summary:
See PHI173. Currently, Herald has an "Assign to" action for tasks, and you can specify custom fields with datasource values (like users or projects) that have a limit (like 1 "Owner", or 12 "Jury Members").

Herald doesn't support these limits right now, so you can write `[ Assign to ][ X, Y, Z ]`. This just means "Assign to X", but make it more clear by actually enforcing the limit in the UI.

Test Plan:
  - Created a "projects" custom field with limit 1.
  - Tried to create actions that 'assign to' or 'set custom field to' more than one thing, got helpfully rebuffed by the UI.
  - Created an "add subscribers" action with more than one value.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18887
2018-01-22 11:54:12 -08:00
..
action Allow Herald rules to add comments 2017-12-18 09:10:57 -08:00
adapter Don't run Herald build and mail rules when they don't make sense 2017-10-27 08:44:12 -07:00
application Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
config Extend from Phobject 2015-06-15 18:02:27 +10:00
contentsource Modularize content sources 2016-03-26 11:59:45 -07:00
controller Don't run Herald build and mail rules when they don't make sense 2017-10-27 08:44:12 -07:00
editor Drive Herald edits via transactions 2016-03-28 23:02:41 +00:00
engine Don't run Herald build and mail rules when they don't make sense 2017-10-27 08:44:12 -07:00
engineextension Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
field Don't run Herald build and mail rules when they don't make sense 2017-10-27 08:44:12 -07:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
group Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
phid In Remarkup, render archived Herald rules with strikethrough for consistency 2016-12-08 12:37:54 -08:00
query Reduce application search engine results list for Dashboards 2017-02-22 12:42:43 -08:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
state Prepare TransactionEditor for silent transactions via bulk edit 2018-01-19 13:23:38 -08:00
storage Don't run Herald build and mail rules when they don't make sense 2017-10-27 08:44:12 -07:00
typeahead Search builds based on who kicked them off 2016-07-31 20:54:44 +00:00
value Respect token limits for "Assign to" and custom datasource fields in Herald 2018-01-22 11:54:12 -08:00